netdev - Re: [PATCH v4 net-next 1/8] virtio: introduce extended features

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250619082223.58cb938c@kernel.org>
Date: Thu, 19 Jun 2025 08:22:23 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Paolo Abeni <pabeni@...hat.com>
Cc: "Michael S. Tsirkin" <mst@...hat.com>, netdev@...r.kernel.org, Willem de
 Bruijn <willemdebruijn.kernel@...il.com>, Jason Wang <jasowang@...hat.com>,
 Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Xuan Zhuo
 <xuanzhuo@...ux.alibaba.com>, Eugenio Pérez
 <eperezma@...hat.com>, Yuri Benditovich <yuri.benditovich@...nix.com>,
 Akihiko Odaki <akihiko.odaki@...nix.com>
Subject: Re: [PATCH v4 net-next 1/8] virtio: introduce extended features

On Thu, 19 Jun 2025 16:36:57 +0200 Paolo Abeni wrote:
> On 6/19/25 4:14 AM, Jakub Kicinski wrote:
> > On Tue, 17 Jun 2025 18:12:08 +0200 Paolo Abeni wrote:  
> >> -	u64 features;
> >> +	VIRTIO_DECLARE_FEATURES(features);  
> > 
> > FWIW this makes kdoc upset. There is a list of regexps in
> > scripts/kernel-doc.pl which make it understand the declaration macros.
> > I think VIRTIO_DECLARE_FEATURES() needs to be added to that list.  
> 
> I guess the preferred course of action is sharing a v5 including a
> scripts/kernel-doc.pl patch, right?

Not a hard ask, but yes that'd be preferable. Unfortunately kdoc build
issues gate passing the patches to selftest stage as they often cause
htmldoc build issues as well.