netdev - Re: [PATCH] rust: cast to the proper type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJ-ks9mazp=gSqDEzUuh0eTvj6pBET-z2zz7XQzmu9at=4V03A@mail.gmail.com>
Date: Thu, 19 Jun 2025 11:29:56 -0400
From: Tamir Duberstein <tamird@...il.com>
To: FUJITA Tomonori <fujita.tomonori@...il.com>
Cc: aliceryhl@...gle.com, tmgross@...ch.edu, ojeda@...nel.org, 
	alex.gaynor@...il.com, boqun.feng@...il.com, gary@...yguo.net, 
	bjorn3_gh@...tonmail.com, lossin@...nel.org, a.hindborg@...nel.org, 
	dakr@...nel.org, davem@...emloft.net, andrew@...n.ch, netdev@...r.kernel.org, 
	rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rust: cast to the proper type

On Wed, Jun 11, 2025 at 8:54 PM Tamir Duberstein <tamird@...il.com> wrote:
>
> On Wed, Jun 11, 2025 at 8:48 PM FUJITA Tomonori
> <fujita.tomonori@...il.com> wrote:
> >
> > On Wed, 11 Jun 2025 09:30:46 -0400
> > Tamir Duberstein <tamird@...il.com> wrote:
> >
> > > On Wed, Jun 11, 2025 at 7:42 AM Alice Ryhl <aliceryhl@...gle.com> wrote:
> > >>
> > >> On Wed, Jun 11, 2025 at 12:28 PM Tamir Duberstein <tamird@...il.com> wrote:
> > >> >
> > >> > Use the ffi type rather than the resolved underlying type.
> > >> >
> > >> > Fixes: f20fd5449ada ("rust: core abstractions for network PHY drivers")
> > >>
> > >> Does this need to be backported? If not, I wouldn't include a Fixes tag.
> > >
> > > I'm fine with omitting it. I wanted to leave a breadcrumb to the
> > > commit that introduced the current code.
> >
> > I also don't think this tag is necessary because this is not a bug
> > fix. And since this tag points to the file's initial commit, I don't
> > think it's particularly useful.
>
> Would you be OK stripping the tag on apply, or would you like me to send v2?

Hi Tomo, gentle ping here. Does this look reasonable to you, with the
Fixes tag stripped on apply?