netdev - Re: [PATCH v4 01/13] dt-bindings: net: mediatek,net: update for mt7988

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9BC433E2-B764-4DE6-A760-D054D981F652@public-files.de>
Date: Thu, 19 Jun 2025 09:27:23 +0200
From: Frank Wunderlich <frank-w@...lic-files.de>
To: "Rob Herring (Arm)" <robh@...nel.org>, Frank Wunderlich <linux@...web.de>
CC: DENG Qingfang <dqfext@...il.com>, Jia-Wei Chang <jia-wei.chang@...iatek.com>,
 Sean Wang <sean.wang@...iatek.com>, Landen Chao <Landen.Chao@...iatek.com>,
 Jakub Kicinski <kuba@...nel.org>, Lorenzo Bianconi <lorenzo@...nel.org>,
 devicetree@...r.kernel.org, Georgi Djakov <djakov@...nel.org>,
 linux-kernel@...r.kernel.org, Chanwoo Choi <cw00.choi@...sung.com>,
 linux-arm-kernel@...ts.infradead.org,
 Arınç ÜNAL <arinc.unal@...nc9.com>,
 linux-mediatek@...ts.infradead.org, linux-pm@...r.kernel.org,
 Kyungmin Park <kyungmin.park@...sung.com>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 Felix Fietkau <nbd@....name>, "David S. Miller" <davem@...emloft.net>,
 Andrew Lunn <andrew@...n.ch>, Matthias Brugger <matthias.bgg@...il.com>,
 Eric Dumazet <edumazet@...gle.com>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 netdev@...r.kernel.org, Daniel Golle <daniel@...rotopia.org>,
 Conor Dooley <conor+dt@...nel.org>, Vladimir Oltean <olteanv@...il.com>,
 Paolo Abeni <pabeni@...hat.com>, MyungJoo Ham <myungjoo.ham@...sung.com>,
 Johnson Wang <johnson.wang@...iatek.com>
Subject: Re: [PATCH v4 01/13] dt-bindings: net: mediatek,net: update for mt7988

Am 18. Juni 2025 19:38:07 MESZ schrieb "Rob Herring (Arm)" <robh@...nel.org>:
>
>On Mon, 16 Jun 2025 11:58:11 +0200, Frank Wunderlich wrote:
>> From: Frank Wunderlich <frank-w@...lic-files.de>
>> 
>> Update binding for mt7988 which has 3 gmac and 2 reg items.
>> 
>> With RSS-IRQs the interrupt max-items is now 6. Add interrupt-names
>> to make them accessible by name.
>> 
>> Signed-off-by: Frank Wunderlich <frank-w@...lic-files.de>
>> ---
>> v4:
>> - increase max interrupts to 8 because of RSS/LRO interrupts
>> - dropped Robs RB due to this change
>> - allow interrupt names
>> - add interrupt-names without reserved IRQs on mt7988
>>   this requires mtk driver patch:
>>   https://patchwork.kernel.org/project/netdevbpf/patch/20250616080738.117993-2-linux@fw-web.de/
>> 
>> v2:
>> - change reg to list of items
>> ---
>>  .../devicetree/bindings/net/mediatek,net.yaml | 28 ++++++++++++++++---
>>  1 file changed, 24 insertions(+), 4 deletions(-)
>> 
>
>Reviewed-by: Rob Herring (Arm) <robh@...nel.org>

Thank you rob.

Have you seen my reponse to coverletter? Got info from mtk that reserved irqs are not unusable (only currently unused) and imho they should be upstreamed too but without a special meaning.

What do you think?

I would increase the interupts count to 8 and name the reserved irqs fe0..fe3. can i keep your RB or should i drop it again?

regards Frank