netdev - Re: [PATCH v2 2/2] docs: net: clarify sysctl value constraints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGn2d8M=Q9DdknYwSUtdb-TMks4CEmMmbNEnSesJA66ahLT7wQ@mail.gmail.com>
Date: Sat, 21 Jun 2025 00:51:25 +0300
From: Abdelrahman Fekry <abdelrahmanfekry375@...il.com>
To: Simon Horman <horms@...nel.org>
Cc: corbet@....net, davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, 
	pabeni@...hat.com, linux-doc@...r.kernel.org, 
	linux-kernel-mentees@...ts.linux.dev, linux-kernel@...r.kernel.org, 
	netdev@...r.kernel.org, skhan@...uxfoundation.com, jacob.e.keller@...el.com, 
	alok.a.tiwari@...cle.com
Subject: Re: [PATCH v2 2/2] docs: net: clarify sysctl value constraints

On Tue, Jun 17, 2025 at 9:12 PM Simon Horman <horms@...nel.org> wrote:
> In his review of v1 [*] Jacob said:
>
>   "Hm. In many cases any non-zero value might be interpreted as "enabled" I
>    suppose that is simply "undefined behavior"?
>
> Looking over the parsing and use of ip_forward_use_pmtu (I did not check
> the other parameters whose documentation this patch updates) I would take
> Jacob's remark a few steps further.
>
> It seems to me that values of 0-255 are accepted and while 0 means
> disabled, all the other values mean enabled. That is because that
> what the code does. And being part of the UAPI it can't be changed.
>
> So I don't think it is correct to describe only values 0/1 having defined
> behaviour. Because the code defines behaviour for all the values in the
> range 0-255.
>
> [*] https://lore.kernel.org/netdev/8b53b5be-82eb-458c-8269-d296bffcef33@intel.com/
>
> ...

well , Thanks for the clarification , i will only keep patch 1/2 in
the next post