netdev - Re: [PATCH net-next 10/10] net: ethtool: don't mux RXFH via rxnfc callbacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250620095012.GD194429@horms.kernel.org>
Date: Fri, 20 Jun 2025 10:50:12 +0100
From: Simon Horman <horms@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
	pabeni@...hat.com, andrew+netdev@...n.ch,
	ajit.khaparde@...adcom.com, sriharsha.basavapatna@...adcom.com,
	somnath.kotur@...adcom.com, shenjian15@...wei.com,
	salil.mehta@...wei.com, shaojijie@...wei.com, cai.huoqing@...ux.dev,
	saeedm@...dia.com, tariqt@...dia.com, louis.peens@...igine.com,
	mbloch@...dia.com, manishc@...vell.com, ecree.xilinx@...il.com,
	joe@...a.to
Subject: Re: [PATCH net-next 10/10] net: ethtool: don't mux RXFH via rxnfc
 callbacks

On Wed, Jun 18, 2025 at 01:38:23PM -0700, Jakub Kicinski wrote:
> All drivers have been converted. Stop using the rxnfc fallbacks
> for Rx Flow Hashing configuration.
> 
> Joe pointed out in earlier review that in ethtool_set_rxfh()
> we need both .get_rxnfc and .get_rxfh_fields, because we need
> both the ring count and flow hashing (because we call
> ethtool_check_flow_types()). IOW the existing check added
> for transitioning drivers was buggy.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Simon Horman <horms@...nel.org>