netdev - Re: [PATCH net-next RFC] net: Throw ASSERT_RTNL into phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5c32afad-5e25-4a35-8bdd-b78949c117ce@lunn.ch>
Date: Sat, 21 Jun 2025 10:01:47 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Kory Maincent <kory.maincent@...tlin.com>
Cc: netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-actions@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linux-renesas-soc@...r.kernel.org, linux-usb@...r.kernel.org,
	Maxime Chevallier <maxime.chevallier@...tlin.com>,
	thomas.petazzoni@...tlin.com, Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Andreas Färber <afaerber@...e.de>,
	Manivannan Sadhasivam <mani@...nel.org>,
	Mark Einon <mark.einon@...il.com>,
	Shyam Sundar S K <Shyam-sundar.S-k@....com>,
	Iyappan Subramanian <iyappan@...amperecomputing.com>,
	Keyur Chudgar <keyur@...amperecomputing.com>,
	Quan Nguyen <quan@...amperecomputing.com>,
	Łukasz Stelmach <l.stelmach@...sung.com>,
	Michael Chan <michael.chan@...adcom.com>,
	Rafał Miłecki <rafal@...ecki.pl>,
	Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>,
	Doug Berger <opendmb@...il.com>,
	Florian Fainelli <florian.fainelli@...adcom.com>,
	Pavan Chebbi <pavan.chebbi@...adcom.com>,
	Sunil Goutham <sgoutham@...vell.com>,
	Hans Ulli Kroll <ulli.kroll@...glemail.com>,
	Linus Walleij <linus.walleij@...aro.org>,
	Ioana Ciornei <ioana.ciornei@....com>,
	Jijie Shao <shaojijie@...wei.com>,
	Jian Shen <shenjian15@...wei.com>,
	Salil Mehta <salil.mehta@...wei.com>,
	Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
	Parthiban Veerasooran <parthiban.veerasooran@...rochip.com>,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
	Niklas Söderlund <niklas.soderlund@...natech.se>,
	MD Danish Anwar <danishanwar@...com>,
	Roger Quadros <rogerq@...nel.org>,
	Jiawen Wu <jiawenwu@...stnetic.com>,
	Mengyuan Lou <mengyuanlou@...-swift.com>,
	Imre Kaloz <kaloz@...nwrt.org>,
	Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>,
	Steve Glendinning <steve.glendinning@...well.net>,
	UNGLinuxDriver@...rochip.com, Simon Horman <horms@...nel.org>,
	Vladimir Oltean <olteanv@...il.com>,
	Richard Cochran <richardcochran@...il.com>
Subject: Re: [PATCH net-next RFC] net: Throw ASSERT_RTNL into phy_detach

> +/**
> + * phy_disconnect_rtnl - disable interrupts, stop state machine, and detach a PHY
> + *		    device
> + * @phydev: target phy_device struct
> + *
> + * This is a wrapper around phy_disconnect that takes the rtnl semaphore.
> + */

Developers are likely to get this wrong, because generally they don't
need to bother with RTNL, the core does it. Could you add some
guidance here when this should be used, and when not.

	Andrew