netdev - Re: [PATCH net 2/2] selftests/tc-testing: Add tests for restrictions on netem duplication

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <574038c3-7013-49a4-ba72-2b40fcec9e5e@mojatatu.com>
Date: Mon, 23 Jun 2025 12:31:09 -0300
From: Victor Nogueira <victor@...atatu.com>
To: William Liu <will@...lsroot.io>, netdev@...r.kernel.org
Cc: jhs@...atatu.com, xiyou.wangcong@...il.com, pctammela@...atatu.com,
 pabeni@...hat.com, kuba@...nel.org, stephen@...workplumber.org,
 dcaratti@...hat.com, savy@...t3mfailure.io, jiri@...nulli.us,
 davem@...emloft.net, edumazet@...gle.com, horms@...nel.org
Subject: Re: [PATCH net 2/2] selftests/tc-testing: Add tests for restrictions
 on netem duplication

> Ensure that a duplicating netem cannot exist in a tree with other netems
> in both qdisc addition and change. This is meant to prevent the soft
> lockup and OOM loop scenario discussed in [1].

Can you add a new test case that checks for netem duplicate in 2 different
branches? Something similar to what test case "bf1d" is doing.

>  [...]
> diff --git a/tools/testing/selftests/tc-testing/tc-tests/qdiscs/netem.json b/tools/testing/selftests/tc-testing/tc-tests/qdiscs/netem.json
> index 3c4444961488..e46a97e75f4b 100644
> --- a/tools/testing/selftests/tc-testing/tc-tests/qdiscs/netem.json
> +++ b/tools/testing/selftests/tc-testing/tc-tests/qdiscs/netem.json
> @@ -336,5 +336,46 @@
>           "teardown": [
>               "$TC qdisc del dev $DUMMY handle 1: root"
>           ]
> +    },
> +    {
> +        "id": "d34d",
> +        "name": "NETEM test qdisc duplication restriction in qdisc tree",
> +        "category": ["qdisc", "netem"],
> +        "plugins": {
> +            "requires": "nsPlugin"
> +        },
> +        "setup": [
> +            "$IP link set lo up || true",
> +            "$TC qdisc add dev lo root handle 1: netem limit 1 duplicate 100%"

It would be better to use dummy instead of lo like the other test cases in
this file.

cheers,
Victor