netdev - Re: [PATCH net 1/1] net: cadence: macb: only register MDIO bus when an MDIO child node exists in DT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bdabd8af-ca82-4435-9d6c-571be9a2e3ed@lunn.ch>
Date: Tue, 24 Jun 2025 00:41:34 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Jonas Karlsson <jonas.d.karlsson@...il.com>
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH net 1/1] net: cadence: macb: only register MDIO bus when
 an MDIO child node exists in DT

On Mon, Jun 23, 2025 at 05:52:13PM +0200, Jonas Karlsson wrote:
> Prior to this patch, the MDIO peripheral was enabled for every GEM
> instance, even if no MDIO child node was defined in the device tree.
> In a setup where gem1 shares the MDIO bus with gem0 but has no MDIO
> subnode, gem1 would still scan the bus (both Clause 22 and Clause 45),
> adding unnecessary delay to the boot sequence.
> 
> This patch changes the driver so that each GEM instance only registers
> its MDIO bus if it has an explicit MDIO child node in DT, e.g.:

What is missing is a paragraph starting something like:

This is safe and won't cause any regressions because ....

When writing this paragraph, please take into account:

https://elixir.bootlin.com/linux/v6.15.3/source/drivers/net/ethernet/cadence/macb_main.c#L818


    Andrew

---
pw-bot: cr