netdev - Re: [PATCH net-next 6/8] net: s/dev_get_flags/netif_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aFnhkk50Q0YBYXWs@mini-arch>
Date: Mon, 23 Jun 2025 16:21:54 -0700
From: Stanislav Fomichev <stfomichev@...il.com>
To: Stanislav Fomichev <sdf@...ichev.me>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com
Subject: Re: [PATCH net-next 6/8] net: s/dev_get_flags/netif_get_flags/

On 06/23, Stanislav Fomichev wrote:
> On 06/23, Stanislav Fomichev wrote:
> > Maintain netif vs dev semantics.
> > 
> > Signed-off-by: Stanislav Fomichev <sdf@...ichev.me>
> > ---
> >  drivers/infiniband/sw/rxe/rxe_verbs.c |  2 +-
> >  fs/smb/server/smb2pdu.c               |  2 +-
> >  include/linux/netdevice.h             |  2 +-
> >  net/8021q/vlan.c                      |  2 +-
> >  net/bridge/br_netlink.c               |  2 +-
> >  net/core/dev.c                        | 10 +++++-----
> >  net/core/dev_ioctl.c                  |  2 +-
> >  net/core/rtnetlink.c                  |  4 ++--
> >  net/ipv4/fib_frontend.c               |  2 +-
> >  net/ipv4/fib_semantics.c              |  2 +-
> >  net/ipv4/nexthop.c                    |  2 +-
> >  net/ipv6/addrconf.c                   |  2 +-
> >  net/mpls/af_mpls.c                    |  6 +++---
> >  net/wireless/wext-core.c              |  2 +-
> >  14 files changed, 21 insertions(+), 21 deletions(-)
> 
> Looks like I missed something in vlan_device_event:
> 
> net/8021q/vlan.c: In function ‘vlan_device_event’:
> net/8021q/vlan.c:507:24: error: implicit declaration of function ‘dev_get_flags’; did you mean ‘dev_get_alias’? [-Werror=implicit-function-declaration]
>   507 |                 flgs = dev_get_flags(dev);
>       |                        ^~~~~~~~~~~~~
>       |                        dev_get_alias
> 
> ---
> pw-bot: cr

I actually got a conflict with https://lore.kernel.org/netdev/20250623113008.695446-1-dongchenchen2@huawei.com/
so will wait a bit for this to be sorted out before reposting..