netdev - Re: [PATCH] atm: idt77252: Add missing `dma_map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250623164041.66ef9cb3@kernel.org>
Date: Mon, 23 Jun 2025 16:40:41 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Thomas Fourier <fourier.thomas@...il.com>
Cc: Chas Williams <3chas3@...il.com>,
 linux-atm-general@...ts.sourceforge.net (moderated list:ATM),
 netdev@...r.kernel.org (open list:ATM), linux-kernel@...r.kernel.org (open
 list)
Subject: Re: [PATCH] atm: idt77252: Add missing `dma_map_error()`

On Thu, 19 Jun 2025 12:57:06 +0200 Thomas Fourier wrote:
> @@ -1857,6 +1859,8 @@ add_rx_skb(struct idt77252_dev *card, int queue,
>  		paddr = dma_map_single(&card->pcidev->dev, skb->data,
>  				       skb_end_pointer(skb) - skb->data,
>  				       DMA_FROM_DEVICE);
> +		if (dma_mapping_error(&card->pcidev->dev, paddr))
> +			goto outfree;
>  		IDT77252_PRV_PADDR(skb) = paddr;
>  
>  		if (push_rx_skb(card, skb, queue)) {

Hm, you're missing undoing sb_pool_add()

Like in another patch from you -- either jump to a new label in between 
the existing two which does the necessary unwind, or move the mapping
earlier, before we start adding the skb into the SW queue.
-- 
pw-bot: cr