netdev - Re: [Intel-wired-lan] [PATCH iwl-next] ice: convert ice_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7f86080f-5cb1-41a8-a031-2664eb0591d5@intel.com>
Date: Mon, 23 Jun 2025 10:50:31 +0200
From: Przemek Kitszel <przemyslaw.kitszel@...el.com>
To: Paul Menzel <pmenzel@...gen.mpg.de>
CC: <intel-wired-lan@...ts.osuosl.org>, Tony Nguyen
	<anthony.l.nguyen@...el.com>, <netdev@...r.kernel.org>, Jacob Keller
	<jacob.e.keller@...el.com>, Aleksandr Loktionov
	<aleksandr.loktionov@...el.com>, Jesse Brandeburg
	<jbrandeburg@...udflare.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next] ice: convert ice_add_prof() to
 bitmap

On 6/18/25 13:54, Paul Menzel wrote:
> Dear Przemek, dear Jesse,
> 
> 
> Thank you for the patch.
> 
> Am 18.06.25 um 13:28 schrieb Przemek Kitszel:
>> From: Jesse Brandeburg <jesse.brandeburg@...el.com>
>>
>> Previously the ice_add_prof() took an array of u8 and looped over it with
>> for_each_set_bit(), examining each 8 bit value as a bitmap.
>> This was just hard to understand and unnecessary, and was triggering
>> undefined behavior sanitizers with unaligned accesses within bitmap
>> fields (on our internal tools/builds). Since the @ptype being passed in
>> was already declared as a bitmap, refactor this to use native types with
>> the advantage of simplifying the code to use a single loop.
> 
> Any tests to verify no regressions are introduced?

Hi, nothing specific, and nothing that could not be inferred from the
commit message, if our VAL would ask me, the reply would be: please test
against FDIR regressions :)

Alexandr has this patch included in a bigger pile of work, which passed
many tests, this is also a form we have present in our OOT driver for
about 3 years by now.

[...]

> Reviewed-by: Paul Menzel <pmenzel@...gen.mpg.de>

Thank you!

> 
> 
> Kind regards,
> 
> Paul