netdev - Re: [PATCH iproute2-next v4 2/3] bridge: dump mcast querier per vlan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fe7f1941-77c5-41a7-b892-ec4f42d45e9f@blackwall.org>
Date: Mon, 23 Jun 2025 12:06:58 +0300
From: Nikolay Aleksandrov <razor@...ckwall.org>
To: Fabian Pfitzner <f.pfitzner@...gutronix.de>, netdev@...r.kernel.org
Cc: dsahern@...il.com, idosch@...dia.com, bridge@...ts.linux-foundation.org,
 entwicklung@...gutronix.de
Subject: Re: [PATCH iproute2-next v4 2/3] bridge: dump mcast querier per vlan

On 6/23/25 11:45, Fabian Pfitzner wrote:
> Dump the multicast querier state per vlan.
> This commit is almost identical to [1].
> 
> The querier state can be seen with:
> 
> bridge -d vlan global
> 
> The options for vlan filtering and vlan mcast snooping have to be enabled
> in order to see the output:
> 
> ip link set [dev] type bridge mcast_vlan_snooping 1 vlan_filtering 1
> 
> The querier state shows the following information for IPv4 and IPv6
> respectively:
> 
> 1) The ip address of the current querier in the network. This could be
>    ourselves or an external querier.
> 2) The port on which the querier was seen
> 3) Querier timeout in seconds
> 
> [1] https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=16aa4494d7fc6543e5e92beb2ce01648b79f8fa2
> 
> Signed-off-by: Fabian Pfitzner <f.pfitzner@...gutronix.de>
> ---
>  bridge/vlan.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/bridge/vlan.c b/bridge/vlan.c
> index 14b8475d..d2770eff 100644
> --- a/bridge/vlan.c
> +++ b/bridge/vlan.c
> @@ -852,6 +852,10 @@ static void print_vlan_global_opts(struct rtattr *a, int ifindex)
>  		print_uint(PRINT_ANY, "mcast_querier", "mcast_querier %u ",
>  			   rta_getattr_u8(vattr));
>  	}
> +	if (vtb[BRIDGE_VLANDB_GOPTS_MCAST_QUERIER_STATE]) {
> +		struct rtattr *attr = vtb[BRIDGE_VLANDB_GOPTS_MCAST_QUERIER_STATE];
> +		bridge_print_mcast_querier_state(attr);
> +	}
>  	if (vtb[BRIDGE_VLANDB_GOPTS_MCAST_IGMP_VERSION]) {
>  		vattr = vtb[BRIDGE_VLANDB_GOPTS_MCAST_IGMP_VERSION];
>  		print_uint(PRINT_ANY, "mcast_igmp_version",
> --
> 2.39.5
> 

Same warning here,

WARNING: Missing a blank line after declarations
#112: FILE: bridge/vlan.c:857:
+		struct rtattr *attr = vtb[BRIDGE_VLANDB_GOPTS_MCAST_QUERIER_STATE];
+		bridge_print_mcast_querier_state(attr);