netdev - Re: [Intel-wired-lan] [PATCH iwl-net v1] ice: check correct pointer in fwlog debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4376ccbe-e688-49b0-bef1-42b46387be25@molgen.mpg.de>
Date: Tue, 24 Jun 2025 12:16:52 +0200
From: Paul Menzel <pmenzel@...gen.mpg.de>
To: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
Cc: intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
 przemyslaw.kitszel@...el.com
Subject: Re: [Intel-wired-lan] [PATCH iwl-net v1] ice: check correct pointer
 in fwlog debugfs

Dear Michal,


Thank you for the patch.

Am 24.06.25 um 11:26 schrieb Michal Swiatkowski:
> pf->ice_debugfs_pf_fwlog should be check for an error here.

be check*ed*

> Fixes: 96a9a9341cda ("ice: configure FW logging")
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> Signed-off-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
> ---
>   drivers/net/ethernet/intel/ice/ice_debugfs.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/intel/ice/ice_debugfs.c b/drivers/net/ethernet/intel/ice/ice_debugfs.c
> index 9fc0fd95a13d..cb71eca6a85b 100644
> --- a/drivers/net/ethernet/intel/ice/ice_debugfs.c
> +++ b/drivers/net/ethernet/intel/ice/ice_debugfs.c
> @@ -606,7 +606,7 @@ void ice_debugfs_fwlog_init(struct ice_pf *pf)
>   
>   	pf->ice_debugfs_pf_fwlog = debugfs_create_dir("fwlog",
>   						      pf->ice_debugfs_pf);
> -	if (IS_ERR(pf->ice_debugfs_pf))
> +	if (IS_ERR(pf->ice_debugfs_pf_fwlog))
>   		goto err_create_module_files;
>   
>   	fw_modules_dir = debugfs_create_dir("modules",

With the above fixed:

Reviewed-by: Paul Menzel <pmenzel@...gen.mpg.de>


Kind regards,

Paul