netdev - Re: [PATCH iproute2-next v5 1/3] bridge: move mcast querier dumping code into a shared function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aFqSNpyVFt85XJbm@shredder>
Date: Tue, 24 Jun 2025 14:55:34 +0300
From: Ido Schimmel <idosch@...dia.com>
To: Fabian Pfitzner <f.pfitzner@...gutronix.de>
Cc: netdev@...r.kernel.org, dsahern@...il.com,
	bridge@...ts.linux-foundation.org, entwicklung@...gutronix.de,
	razor@...ckwall.org
Subject: Re: [PATCH iproute2-next v5 1/3] bridge: move mcast querier dumping
 code into a shared function

On Mon, Jun 23, 2025 at 11:33:16AM +0200, Fabian Pfitzner wrote:
> Put mcast querier dumping code into a shared function. This function
> will be called from the bridge utility in a later patch.
> 
> Adapt the code such that the vtb parameter is used
> instead of tb[IFLA_BR_MCAST_QUERIER_STATE].
> 
> Signed-off-by: Fabian Pfitzner <f.pfitzner@...gutronix.de>

Reviewed-by: Ido Schimmel <idosch@...dia.com>

[...]

> +void bridge_print_mcast_querier_state(const struct rtattr *vtb)
> +{
> +	struct rtattr *bqtb[BRIDGE_QUERIER_MAX + 1];
> +

I assume you added the blank line because of checkpatch, but I think
it's wrong in this case.

> +	SPRINT_BUF(other_time);
> +
> +	parse_rtattr_nested(bqtb, BRIDGE_QUERIER_MAX, vtb);
> +	memset(other_time, 0, sizeof(other_time));