netdev - Re: [PATCH iproute2-next v5 3/3] bridge: refactor bridge mcast querier function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aFqTkm2SH7189QXL@shredder>
Date: Tue, 24 Jun 2025 15:01:22 +0300
From: Ido Schimmel <idosch@...dia.com>
To: Fabian Pfitzner <f.pfitzner@...gutronix.de>
Cc: netdev@...r.kernel.org, dsahern@...il.com,
	bridge@...ts.linux-foundation.org, entwicklung@...gutronix.de,
	razor@...ckwall.org
Subject: Re: [PATCH iproute2-next v5 3/3] bridge: refactor bridge mcast
 querier function

On Mon, Jun 23, 2025 at 11:33:20AM +0200, Fabian Pfitzner wrote:
> Make code more readable and consistent with other functions.
> 
> Signed-off-by: Fabian Pfitzner <f.pfitzner@...gutronix.de>

Reviewed-by: Ido Schimmel <idosch@...dia.com>

> ---
>  lib/bridge.c | 72 +++++++++++++++++++++++++---------------------------
>  1 file changed, 34 insertions(+), 38 deletions(-)
> 
> diff --git a/lib/bridge.c b/lib/bridge.c
> index 480693c9..23a102c4 100644
> --- a/lib/bridge.c
> +++ b/lib/bridge.c
> @@ -49,60 +49,56 @@ void bridge_print_vlan_stats(const struct bridge_vlan_xstats *vstats)
>  void bridge_print_mcast_querier_state(const struct rtattr *vtb)
>  {
>  	struct rtattr *bqtb[BRIDGE_QUERIER_MAX + 1];
> +	const char *querier_ip;
> 
>  	SPRINT_BUF(other_time);
> +	__u64 tval;

I suggest removing the blank line before "other_time"

> 
>  	parse_rtattr_nested(bqtb, BRIDGE_QUERIER_MAX, vtb);
>  	memset(other_time, 0, sizeof(other_time));