netdev - Re: [PATCH net-next v5] docs: net: sysctl documentation cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGn2d8OguuLUkRaT68MkL0_VJ5hh5CZfONCaruEHcASdxfJbDA@mail.gmail.com>
Date: Tue, 24 Jun 2025 15:59:18 +0300
From: Abdelrahman Fekry <abdelrahmanfekry375@...il.com>
To: Paolo Abeni <pabeni@...hat.com>
Cc: corbet@....net, davem@...emloft.net, edumazet@...gle.com, horms@...nel.org, 
	kuba@...nel.org, linux-doc@...r.kernel.org, 
	linux-kernel-mentees@...ts.linux.dev, linux-kernel@...r.kernel.org, 
	netdev@...r.kernel.org, skhan@...uxfoundation.com, jacob.e.keller@...el.com, 
	alok.a.tiwari@...cle.com, bagasdotme@...il.com
Subject: Re: [PATCH net-next v5] docs: net: sysctl documentation cleanup

On Tue, Jun 24, 2025 at 3:54 PM Paolo Abeni <pabeni@...hat.com> wrote:
>
> On 6/22/25 11:07 AM, Abdelrahman Fekry wrote:
> > @@ -593,10 +629,16 @@ tcp_min_rtt_wlen - INTEGER
> >       Default: 300
> >
> >  tcp_moderate_rcvbuf - BOOLEAN
> > -     If set, TCP performs receive buffer auto-tuning, attempting to
> > +     If enabled, TCP performs receive buffer auto-tuning, attempting to
> >       automatically size the buffer (no greater than tcp_rmem[2]) to
> > -     match the size required by the path for full throughput.  Enabled by
> > -     default.
> > +     match the size required by the path for full throughput.
> > +
> > +     Possible values:
> > +
> > +     - 0 (disabled)
> > +     - 1 (enabled)
> > +
> > +     Default: 0 (disabled)
>
> This uncorrectly changes the default value: should be 1.
>
> >  icmp_echo_ignore_broadcasts - BOOLEAN
> > -     If set non-zero, then the kernel will ignore all ICMP ECHO and
> > +     If enabled, then the kernel will ignore all ICMP ECHO and
> >       TIMESTAMP requests sent to it via broadcast/multicast.
> >
> > -     Default: 1
> > +     Possible values:
> > +
> > +     - 0 (disabled)
> > +     - 1 (enabled)
> > +
> > +     Default: 0 (disabled)
>
> Same here.
>
Thanks for feedback , will change it and look for other mistakes
> /P
>