netdev - RE: [PATCH v20 net-next 0/6] DUALPI2 patch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID:
 <VI1PR07MB5567EDDD3F6F999B7B082575B978A@VI1PR07MB5567.eurprd07.prod.outlook.com>
Date: Tue, 24 Jun 2025 13:53:31 +0000
From: "Koen De Schepper (Nokia)" <koen.de_schepper@...ia-bell-labs.com>
To: Ferenc Fejes <ferenc@...es.dev>, "Chia-Yu Chang (Nokia)"
	<chia-yu.chang@...ia-bell-labs.com>, "alok.a.tiwari@...cle.com"
	<alok.a.tiwari@...cle.com>, "pctammela@...atatu.com"
	<pctammela@...atatu.com>, "horms@...nel.org" <horms@...nel.org>,
	"donald.hunter@...il.com" <donald.hunter@...il.com>, "xandfury@...il.com"
	<xandfury@...il.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"dave.taht@...il.com" <dave.taht@...il.com>, "pabeni@...hat.com"
	<pabeni@...hat.com>, "jhs@...atatu.com" <jhs@...atatu.com>, "kuba@...nel.org"
	<kuba@...nel.org>, "stephen@...workplumber.org" <stephen@...workplumber.org>,
	"xiyou.wangcong@...il.com" <xiyou.wangcong@...il.com>, "jiri@...nulli.us"
	<jiri@...nulli.us>, "davem@...emloft.net" <davem@...emloft.net>,
	"edumazet@...gle.com" <edumazet@...gle.com>, "andrew+netdev@...n.ch"
	<andrew+netdev@...n.ch>, "ast@...erby.net" <ast@...erby.net>,
	"liuhangbin@...il.com" <liuhangbin@...il.com>, "shuah@...nel.org"
	<shuah@...nel.org>, "linux-kselftest@...r.kernel.org"
	<linux-kselftest@...r.kernel.org>, "ij@...nel.org" <ij@...nel.org>,
	"ncardwell@...gle.com" <ncardwell@...gle.com>, "g.white@...lelabs.com"
	<g.white@...lelabs.com>, "ingemar.s.johansson@...csson.com"
	<ingemar.s.johansson@...csson.com>, "mirja.kuehlewind@...csson.com"
	<mirja.kuehlewind@...csson.com>, "cheshire@...le.com" <cheshire@...le.com>,
	"rs.ietf@....at" <rs.ietf@....at>, "Jason_Livingood@...cast.com"
	<Jason_Livingood@...cast.com>, "vidhi_goel@...le.com" <vidhi_goel@...le.com>
Subject: RE: [PATCH v20 net-next 0/6] DUALPI2 patch

Hi Ferenc,

We spend a lot of effort on the tc version of DualPI2, mainly to share the know how with others as a reference implementation. I hope this tc realization can be accepted now. 

This shouldn't stop any other realizations (using other technologies) that can be done in parallel by people that are interested in those. The performance and correct functioning of those other realizations can then also be compared/verified with the tc DualPI2.

Regards,
Koen & Chia-Yu.


-----Original Message-----
From: Ferenc Fejes <ferenc@...es.dev> 
Sent: Tuesday, June 24, 2025 2:35 PM
To: Chia-Yu Chang (Nokia) <chia-yu.chang@...ia-bell-labs.com>; alok.a.tiwari@...cle.com; pctammela@...atatu.com; horms@...nel.org; donald.hunter@...il.com; xandfury@...il.com; netdev@...r.kernel.org; dave.taht@...il.com; pabeni@...hat.com; jhs@...atatu.com; kuba@...nel.org; stephen@...workplumber.org; xiyou.wangcong@...il.com; jiri@...nulli.us; davem@...emloft.net; edumazet@...gle.com; andrew+netdev@...n.ch; ast@...erby.net; liuhangbin@...il.com; shuah@...nel.org; linux-kselftest@...r.kernel.org; ij@...nel.org; ncardwell@...gle.com; Koen De Schepper (Nokia) <koen.de_schepper@...ia-bell-labs.com>; g.white@...lelabs.com; ingemar.s.johansson@...csson.com; mirja.kuehlewind@...csson.com; cheshire@...le.com; rs.ietf@....at; Jason_Livingood@...cast.com; vidhi_goel@...le.com
Subject: Re: [PATCH v20 net-next 0/6] DUALPI2 patch

[Some people who received this message don't often get email from ferenc@...es.dev. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]

CAUTION: This is an external email. Please be very careful when clicking links or opening attachments. See the URL nok.it/ext for additional information.



On Sat, 2025-06-21 at 21:33 +0200, chia-yu.chang@...ia-bell-labs.com wrote:
> From: Chia-Yu Chang <chia-yu.chang@...ia-bell-labs.com>
>
> Hello,
>
>   Please find the DualPI2 patch v20.
>
>   This patch serise adds DualPI Improved with a Square (DualPI2) with 
> following features:
> * Supports congestion controls that comply with the Prague 
> requirements in
> RFC9331 (e.g. TCP-Prague)
> * Coupled dual-queue that separates the L4S traffic in a low latency 
> queue (L- queue), without harming remaining traffic that is scheduled 
> in classic queue
> (C-queue) due to congestion-coupling using PI2 as defined in RFC9332
> * Configurable overload strategies
> * Use of sojourn time to reliably estimate queue delay
> * Supports ECN L4S-identifier (IP.ECN==0b*1) to classify traffic into 
> respective queues
>


Looking at this, I wonder if DualPI2 would be implemented in BPF.
For example, you could have two FIFOs with a BPF Qdisc, such as:

struct bpf_list_head l_queue __contains(skb_node, node); struct bpf_list_head c_queue __contains(skb_node, node);

The bpf_list_push_back and bpf_list_pop_front functions are also available for handling these.

There are also spinlock helpers, and the pi2_timer can be replaced with updates based on the struct bpf_timer. Of course, there are tricks to consider regarding GSO, which might require additional BPF helpers. However, looking through the code, I see a chance to implement this as a pure BPF qdisc. What do you think?

Having this as a regular qdisc with the iproute2 tc interface is great, considering the effort already spent on it. However, since all the operational bits are already sorted out, it might be worth looking into the feasibility of a BPF version.

Best,
Ferenc