netdev - Re: [PATCH net-next] net: add sysctl ndisc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aFq2s3SnM1lzuGHb@shredder>
Date: Tue, 24 Jun 2025 17:31:15 +0300
From: Ido Schimmel <idosch@...sch.org>
To: Wang Liang <wangliang74@...wei.com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, horms@...nel.org, dsahern@...nel.org,
	yuehaibing@...wei.com, zhangchangzhong@...wei.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: add sysctl ndisc_debug

On Tue, Jun 24, 2025 at 08:51:15PM +0800, Wang Liang wrote:
> Ipv6 ndisc uses ND_PRINTK to print logs. However it only works when
> ND_DEBUG was set in the compilation phase. This patch adds sysctl
> ndisc_debug, so we can change the print switch when system is running and
> get ipv6 ndisc log to debug.

Is there a good reason to do this instead of using dynamic debug? Note
that we will never be able to remove this sysctl.

Users of vanilla kernels can only see the messages printed with 'val'
being 0 or 1. Maybe convert them to call net_{err,warn}_ratelimited()
instead of ND_PRINTK() and convert the rest to net_dbg_ratelimited() so
that users will be able to enable / disable them during runtime via the
dynamic debug interface?