netdev - [PATCH net 00/10] netlink: specs: enforce strict naming of properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250624211002.3475021-1-kuba@kernel.org>
Date: Tue, 24 Jun 2025 14:09:52 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: davem@...emloft.net,
	donald.hunter@...il.com
Cc: netdev@...r.kernel.org,
	edumazet@...gle.com,
	pabeni@...hat.com,
	andrew+netdev@...n.ch,
	horms@...nel.org,
	Jakub Kicinski <kuba@...nel.org>
Subject: [PATCH net 00/10] netlink: specs: enforce strict naming of properties

I got annoyed once again by the name properties in the ethtool spec
which use underscore instead of dash. I previously assumed that there
is a lot of such properties in the specs so fixing them now would
be near impossible. On a closer look, however, I only found 22
(rough grep suggests we have ~4.8k names in the specs, so bad ones
are just 0.46%).

Add a regex to the JSON schema to enforce the naming, fix the few
bad names. I was hoping we could start enforcing this from newer
families, but there's no correlation between the protocol and the
number of errors. If anything classic netlink has more recently
added specs so it has fewer errors.

The regex is just for name properties which will end up visible
to the user (in Python or YNL CLI). I left the c-name properties
alone, those don't matter as much. C codegen rewrites them, anyway.

I'm not updating the spec for genetlink-c. Looks like it has no
users, new families use genetlink, all old ones need genetlink-legacy.
If these patches are merged I will remove genetlink-c completely
in net-next.

Jakub Kicinski (10):
  netlink: specs: nfsd: replace underscores with dashes in names
  netlink: specs: fou: replace underscores with dashes in names
  netlink: specs: ethtool: replace underscores with dashes in names
  netlink: specs: dpll: replace underscores with dashes in names
  netlink: specs: devlink: replace underscores with dashes in names
  netlink: specs: ovs_flow: replace underscores with dashes in names
  netlink: specs: mptcp: replace underscores with dashes in names
  netlink: specs: rt-link: replace underscores with dashes in names
  netlink: specs: tc: replace underscores with dashes in names
  netlink: specs: enforce strict naming of properties

 Documentation/netlink/genetlink-legacy.yaml   | 15 ++++----
 Documentation/netlink/genetlink.yaml          | 17 +++++----
 Documentation/netlink/netlink-raw.yaml        | 18 ++++++----
 Documentation/netlink/specs/devlink.yaml      |  8 ++---
 Documentation/netlink/specs/dpll.yaml         |  2 +-
 Documentation/netlink/specs/ethtool.yaml      |  6 ++--
 Documentation/netlink/specs/fou.yaml          | 36 +++++++++----------
 Documentation/netlink/specs/mptcp_pm.yaml     |  8 ++---
 Documentation/netlink/specs/nfsd.yaml         |  4 +--
 Documentation/netlink/specs/ovs_flow.yaml     |  6 ++--
 Documentation/netlink/specs/rt-link.yaml      |  4 +--
 Documentation/netlink/specs/tc.yaml           |  4 +--
 include/uapi/linux/mptcp_pm.h                 |  6 ++--
 .../drivers/net/hw/rss_input_xfrm.py          |  2 +-
 14 files changed, 74 insertions(+), 62 deletions(-)

-- 
2.49.0