netdev - Re: [PATCH net-next v2 3/8] net: ethtool: call .parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250624075705.3f10676d@2a02-8440-d115-be0d-cec0-a2a1-bc3c-622e.rev.sfr.net>
Date: Tue, 24 Jun 2025 07:57:05 +0200
From: Maxime Chevallier <maxime.chevallier@...tlin.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
 pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org,
 donald.hunter@...il.com, sdf@...ichev.me, jdamato@...tly.com,
 ecree.xilinx@...il.com
Subject: Re: [PATCH net-next v2 3/8] net: ethtool: call .parse_request for
 SET handlers

On Mon, 23 Jun 2025 16:17:15 -0700
Jakub Kicinski <kuba@...nel.org> wrote:

> In preparation for using req_info to carry parameters between SET
> and NTF - call .parse_request during ethnl_default_set_doit().
> 
> The main question here is whether .parse_request is intended to be
> GET-specific. Originally the SET handling was delegated to each subcommand
> directly - ethnl_default_set_doit() and .set callbacks in ethnl_request_ops
> did not exist. Looking at existing users does not shed much light, all
> of the following subcommands use .parse_request but have no SET handler
> (and no NTF):
> 
>   net/ethtool/eeprom.c
>   net/ethtool/rss.c
>   net/ethtool/stats.c
>   net/ethtool/strset.c
>   net/ethtool/tsinfo.c
> 
> There's only one which does have a SET:
> 
>   net/ethtool/pause.c
> 
> where .parse_request handling is used to select which statistics to query.
> Not relevant for SET but also harmless.
> 
> Going back to RSS (which doesn't have SET today) .parse_request parses
> the rss_context ID. Using the req_info struct to pass the context ID
> from SET to NTF will be very useful.
> 
> Switch to ethnl_default_parse(), effectively adding the .parse_request
> for SET handlers.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Maxime Chevallier <maxime.chevallier@...tlin.com>
Tested-by: Maxime Chevallier <maxime.chevallier@...tlin.com>

Maxime