netdev - Re: [PATCH net-next v2 0/8] net: ethtool: rss: add notifications

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250624080004.7a36543e@2a02-8440-d115-be0d-cec0-a2a1-bc3c-622e.rev.sfr.net>
Date: Tue, 24 Jun 2025 08:00:04 +0200
From: Maxime Chevallier <maxime.chevallier@...tlin.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
 pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org,
 donald.hunter@...il.com, sdf@...ichev.me, jdamato@...tly.com,
 ecree.xilinx@...il.com
Subject: Re: [PATCH net-next v2 0/8] net: ethtool: rss: add notifications

Hi Jakub,

On Mon, 23 Jun 2025 16:17:12 -0700
Jakub Kicinski <kuba@...nel.org> wrote:

> Next step on the path to moving RSS config to Netlink. With the
> refactoring of the driver-facing API for ETHTOOL_GRXFH/ETHTOOL_SRXFH
> out of the way we can move on to more interesting work.
> 
> Add Netlink notifications for changes in RSS configuration.
> 
> As a reminder (part) of rss-get was introduced in previous releases
> when input-xfrm (symmetric hashing) was added. rss-set isn't
> implemented, yet, but we can implement rss-ntf and hook it into
> the changes done via the IOCTL path (same as other ethtool-nl
> notifications do).
> 
> Most of the series is concerned with passing arguments to notifications.
> So far none of the notifications needed to be parametrized, but RSS can
> have multiple contexts per device, and since GET operates on a single
> context at a time, the notification needs to also be scoped to a context.
> Patches 2-5 add support for passing arguments to notifications thru
> ethtool-nl generic infra.
> 
> The notification handling itself is pretty trivial, it's mostly
> hooking in the right entries into the ethool-nl op tables.

I was able to test the PLCA path, which works fine :)

So, I reviewed and tested some of the ethnl patches in this series,
though I wasn't able to test the RSS-specific aspects.

Thanks,

Maxime