[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <923746b8-73d4-483c-b687-388a7cc2b74a@redhat.com>
Date: Tue, 24 Jun 2025 09:28:15 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Alexander Duyck <alexander.duyck@...il.com>, netdev@...r.kernel.org,
linux@...linux.org.uk, hkallweit1@...il.com, andrew+netdev@...n.ch,
davem@...emloft.net, kernel-team@...a.com, edumazet@...gle.com
Subject: Re: [net-next PATCH v3 0/8] Add support for 25G, 50G, and 100G to
fbnic
On 6/20/25 4:36 PM, Jakub Kicinski wrote:
> On Thu, 19 Jun 2025 10:44:41 +0200 Paolo Abeni wrote:
>> Apparently this is causing TSO tests
>
> I had a closer look, I think the TSO test case is always failing,
> the test that didn't fail before but fails now is the test for
> pause statistics. Since the driver didn't support pause config
> before the test returned XFAIL, now there is pause but no stats
> so it fails. I guess we may have been better off using SKIP rather
> than XFAIL in the test case, so that the CI doesn't consider lack
> of results a pass.
Thanks for the pointers. I agree the issue is in the selftests code and
patches LGTM.
Thanks,
Paolo
Powered by blists - more mailing lists