netdev - Re: [PATCH net-next V2] xfrm: hold device only for the asynchronous decryption

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aFu4sUO4+K/tyGxf@gauss3.secunet.de>
Date: Wed, 25 Jun 2025 10:52:01 +0200
From: Steffen Klassert <steffen.klassert@...unet.com>
To: Jianbo Liu <jianbol@...dia.com>
CC: <netdev@...r.kernel.org>, <davem@...emloft.net>, <kuba@...nel.org>,
	"Cosmin Ratiu" <cratiu@...dia.com>, Herbert Xu <herbert@...dor.apana.org.au>,
	"Eric Dumazet" <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Simon
 Horman <horms@...nel.org>
Subject: Re: [PATCH net-next V2] xfrm: hold device only for the asynchronous
 decryption

On Thu, Jun 19, 2025 at 12:48:51PM +0300, Jianbo Liu wrote:
> The dev_hold() on skb->dev during packet reception was originally
> added to prevent the device from being released prematurely during
> asynchronous decryption operations.
> 
> As current hardware can offload decryption, this asynchronous path is
> not always utilized. This often results in a pattern of dev_hold()
> immediately followed by dev_put() for each packet, creating
> unnecessary reference counting overhead detrimental to performance.
> 
> This patch optimizes this by skipping the dev_hold() and subsequent
> dev_put() when asynchronous decryption is not being performed.
> 
> Signed-off-by: Jianbo Liu <jianbol@...dia.com>
> Reviewed-by: Cosmin Ratiu <cratiu@...dia.com>

Applied ,thanks a lot!