netdev - Re: [PATCH net 03/10] netlink: specs: ethtool: replace underscores with dashes in names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m2frfocfo6.fsf@gmail.com>
Date: Wed, 25 Jun 2025 10:51:37 +0100
From: Donald Hunter <donald.hunter@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net,  netdev@...r.kernel.org,  edumazet@...gle.com,
  pabeni@...hat.com,  andrew+netdev@...n.ch,  horms@...nel.org,
  andrew@...n.ch,  shuah@...nel.org,  kory.maincent@...tlin.com,
  sdf@...ichev.me,  gal@...dia.com,  noren@...dia.com,
  ahmed.zaki@...el.com,  wojciech.drewek@...el.com,  petrm@...dia.com,
  danieller@...dia.com,  linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net 03/10] netlink: specs: ethtool: replace underscores
 with dashes in names

Jakub Kicinski <kuba@...nel.org> writes:

> We're trying to add a strict regexp for the name format in the spec.
> Underscores will not be allowed, dashes should be used instead.
> This makes no difference to C (codegen replaces special chars in names)
> but gives more uniform naming in Python.
>
> Fixes: 13e59344fb9d ("net: ethtool: add support for symmetric-xor RSS hash")
> Fixes: 46fb3ba95b93 ("ethtool: Add an interface for flashing transceiver modules' firmware")
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Donald Hunter <donald.hunter@...il.com>