Message-ID:
 <DS7PR19MB888396A80C1A81792185630A9D7BA@DS7PR19MB8883.namprd19.prod.outlook.com>
Date: Wed, 25 Jun 2025 14:24:56 +0400
From: George Moussalem <george.moussalem@...look.com>
To: Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>,
 Russell King <linux@...linux.org.uk>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Florian Fainelli <f.fainelli@...il.com>,
 Philipp Zabel <p.zabel@...gutronix.de>,
 Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>,
 Michael Turquette <mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>
Cc: netdev@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
 linux-clk@...r.kernel.org, Konrad Dybcio <konrad.dybcio@....qualcomm.com>
Subject: Re: [PATCH v5 0/5] Add support for the IPQ5018 Internal GE PHY

Hi,

I've reopened this series and changed status to New for patch 1, 4, and 5
as this series was marked as Superseded to continue the review. 
Jakub requested me to send 2 patches (2 and 3) separately to net-next
which have been merged (thanks!):

Here is the summary with links:
  - [RESEND,net-next,v5,1/2] dt-bindings: net: qca,ar803x: Add IPQ5018 Internal GE PHY support
    https://git.kernel.org/netdev/net-next/c/82eaf94d69fc
  - [RESEND,net-next,v5,2/2] net: phy: qcom: at803x: Add Qualcomm IPQ5018 Internal PHY support
    https://git.kernel.org/netdev/net-next/c/d46502279a11

Patch 1, 4, 5 of this series still need merging.

Thanks,
George 

On 6/10/25 12:37, George Moussalem via B4 Relay wrote:
> The IPQ5018 SoC contains an internal Gigabit Ethernet PHY with its
> output pins that provide an MDI interface to either an external switch
> in a PHY to PHY link architecture or directly to an attached RJ45
> connector.
> 
> The PHY supports 10BASE-T/100BASE-TX/1000BASE-T link modes in SGMII
> interface mode, CDT, auto-negotiation and 802.3az EEE.
> 
> The LDO controller found in the IPQ5018 SoC needs to be enabled to drive
> power to the CMN Ethernet Block (CMN BLK) which the GE PHY depends on.
> The LDO must be enabled in TCSR by writing to a specific register.
> 
> In a phy to phy architecture, DAC values need to be set to accommodate
> for the short cable length.
> 
> Signed-off-by: George Moussalem <george.moussalem@...look.com>
> ---
> Changes in v5:
> - Removed unused macro definition (IPQ5018_TCSR_ETH_LDO_READY)
> - Reverted sorting of header files for which a separate patch can be
>   submitted
> - Added a comment to explain why the FIFO buffer needs to be reset
> - Do not initialize local variable as caught by Russell
> - Updated macro definition names to more accurately describe the PHY
>   registers and their functions
> - Include SGMII as supported interface mode in driver commit message
> - Changed error handling of acquirement of PHY reset to use IR_ERR
>   instead of IS_ERR_OR_NULL
> - Link to v4: https://lore.kernel.org/r/20250609-ipq5018-ge-phy-v4-0-1d3a125282c3@outlook.com
> 
> Changes in v4:
> - Updated description of qcom,dac-preset-short-cable property in
>   accordance with Andrew's recommendation to indicate that if the
>   property is not set, no DAC values will be modified.
> - Added newlines between properties
> - Added PHY ID as compatible in DT bindings for conditional check to
>   evaluate correctly. Did a 'git grep' on all other PHY IDs defined in
>   the driver but none are explicitly referenced so I haven't added them
> - Link to v3: https://lore.kernel.org/r/20250602-ipq5018-ge-phy-v3-0-421337a031b2@outlook.com
> 
> Changes in v3:
> - Replace bitmask of GEPHY_MISC_ARES with GENMASK as suggested by Konrad
> - Removed references to RX and TX clocks as the driver need not
>   explicitly enable them. The GCC gatecontrols and routes the PHY's
>   output clocks, registered in the DT as fixed clocks, back to the PHY.
>   The bindings file has been updated accordingly.
> - Removed acquisition and enablement of RX and TX clocks from the driver
> - Link to v2: https://lore.kernel.org/r/20250528-ipq5018-ge-phy-v2-0-dd063674c71c@outlook.com
> 
> Changes in v2:
> - Moved values for MDAC and EDAC into the driver and converted DT
>   property qca,dac to a new boolean: qcom,dac-preset-short-cable as per
>   discussion.
> - Added compatible string along with a condition with a description of
>   properties including clocks, resets, and qcom,dac-preset-short-cable
>   in the bindings to address bindings issues reported by Rob and to
>   bypass restrictions on nr of clocks and resets in ethernet-phy.yaml
> - Added example to bindings file
> - Renamed all instances of IPQ5018_PHY_MMD3* macros to IPQ5018_PHY_PCS*
> - Removed qca,eth-ldo-ready property and moved the TCSR register to the
>   mdio bus the phy is on as there's already support for setting this reg
>   property in the mdio-ipq4019 driver as per commit:
>   23a890d493e3ec1e957bc925fabb120962ae90a7
> - Explicitly probe on PHY ID as otherwise the PHY wouldn't come up and
>   initialize as found during further testing when the kernel is flashed
>   to NAND
> - Link to v1: https://lore.kernel.org/r/20250525-ipq5018-ge-phy-v1-0-ddab8854e253@outlook.com
> 
> ---
> George Moussalem (5):
>       clk: qcom: gcc-ipq5018: fix GE PHY reset
>       dt-bindings: net: qca,ar803x: Add IPQ5018 Internal GE PHY support
>       net: phy: qcom: at803x: Add Qualcomm IPQ5018 Internal PHY support
>       arm64: dts: qcom: ipq5018: Add MDIO buses
>       arm64: dts: qcom: ipq5018: Add GE PHY to internal mdio bus
> 
>  .../devicetree/bindings/net/qca,ar803x.yaml        |  43 ++++++
>  arch/arm64/boot/dts/qcom/ipq5018.dtsi              |  48 +++++-
>  drivers/clk/qcom/gcc-ipq5018.c                     |   2 +-
>  drivers/net/phy/qcom/Kconfig                       |   2 +-
>  drivers/net/phy/qcom/at803x.c                      | 167 +++++++++++++++++++++
>  5 files changed, 258 insertions(+), 4 deletions(-)
> ---
> base-commit: ebfff09f63e3efb6b75b0328b3536d3ce0e26565
> change-id: 20250430-ipq5018-ge-phy-db654afa4ced
> 
> Best regards,

Powered by blists - more mailing lists