[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250625110824.GA1562@horms.kernel.org>
Date: Wed, 25 Jun 2025 12:08:24 +0100
From: Simon Horman <horms@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
pabeni@...hat.com, andrew+netdev@...n.ch, alexanderduyck@...com,
mohsin.bashr@...il.com
Subject: Re: [PATCH net-next 5/5] eth: fbnic: rename fbnic_fw_clear_cmpl to
fbnic_mbx_clear_cmpl
On Tue, Jun 24, 2025 at 07:28:34AM -0700, Jakub Kicinski wrote:
> fbnic_fw_clear_cmpl() does the inverse of fbnic_mbx_set_cmpl().
> It removes the completion from the mailbox table.
> It also calls fbnic_mbx_set_cmpl_slot() internally.
> It should have fbnic_mbx prefix, not fbnic_fw.
> I'm not very clear on what the distinction is between the two
> prefixes but the matching "set" and "clear" functions should
> use the same prefix.
>
> While at it move the "clear" function closer to the "set".
>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
Reviewed-by: Simon Horman <horms@...nel.org>
Powered by blists - more mailing lists