lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <202506252237.x9hiFnbB-lkp@intel.com>
Date: Wed, 25 Jun 2025 22:38:14 +0800
From: kernel test robot <lkp@...el.com>
To: Tanmay Jagdale <tanmay@...vell.com>, davem@...emloft.net,
	leon@...nel.org, horms@...nel.org, sgoutham@...vell.com,
	bbhushan2@...vell.com, herbert@...dor.apana.org.au
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	linux-crypto@...r.kernel.org, netdev@...r.kernel.org,
	Tanmay Jagdale <tanmay@...vell.com>
Subject: Re: [PATCH net-next v2 14/14] octeontx2-pf: ipsec: Add XFRM state
 and policy hooks for inbound flows

Hi Tanmay,

kernel test robot noticed the following build errors:

[auto build test ERROR on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Tanmay-Jagdale/crypto-octeontx2-Share-engine-group-info-with-AF-driver/20250618-193646
base:   net-next/main
patch link:    https://lore.kernel.org/r/20250618113020.130888-15-tanmay%40marvell.com
patch subject: [PATCH net-next v2 14/14] octeontx2-pf: ipsec: Add XFRM state and policy hooks for inbound flows
config: um-allmodconfig (https://download.01.org/0day-ci/archive/20250625/202506252237.x9hiFnbB-lkp@intel.com/config)
compiler: clang version 19.1.7 (https://github.com/llvm/llvm-project cd708029e0b2869e80abe31ddb175f7c35361f90)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250625/202506252237.x9hiFnbB-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202506252237.x9hiFnbB-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from drivers/net/ethernet/marvell/octeontx2/nic/cn10k_ipsec.c:7:
   In file included from include/net/xfrm.h:9:
   In file included from include/linux/skbuff.h:17:
   In file included from include/linux/bvec.h:10:
   In file included from include/linux/highmem.h:12:
   In file included from include/linux/hardirq.h:11:
   In file included from arch/um/include/asm/hardirq.h:5:
   In file included from include/asm-generic/hardirq.h:17:
   In file included from include/linux/irq.h:20:
   In file included from include/linux/io.h:12:
   In file included from arch/um/include/asm/io.h:24:
   include/asm-generic/io.h:1175:55: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
    1175 |         return (port > MMIO_UPPER_LIMIT) ? NULL : PCI_IOBASE + port;
         |                                                   ~~~~~~~~~~ ^
   drivers/net/ethernet/marvell/octeontx2/nic/cn10k_ipsec.c:924:8: warning: variable 'ptr' set but not used [-Wunused-but-set-variable]
     924 |         void *ptr;
         |               ^
>> drivers/net/ethernet/marvell/octeontx2/nic/cn10k_ipsec.c:1206:2: error: call to undeclared function 'dmb'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
    1206 |         dmb(sy);
         |         ^
>> drivers/net/ethernet/marvell/octeontx2/nic/cn10k_ipsec.c:1206:6: error: use of undeclared identifier 'sy'
    1206 |         dmb(sy);
         |             ^
   2 warnings and 2 errors generated.


vim +/dmb +1206 drivers/net/ethernet/marvell/octeontx2/nic/cn10k_ipsec.c

  1156	
  1157	static int cn10k_inb_write_sa(struct otx2_nic *pf,
  1158				      struct xfrm_state *x,
  1159				      struct cn10k_inb_sw_ctx_info *inb_ctx_info)
  1160	{
  1161		dma_addr_t res_iova, dptr_iova, sa_iova;
  1162		struct cn10k_rx_sa_s *sa_dptr, *sa_cptr;
  1163		struct cpt_inst_s inst;
  1164		u32 sa_size, off;
  1165		struct cpt_res_s *res;
  1166		u64 reg_val;
  1167		int ret;
  1168	
  1169		res = dma_alloc_coherent(pf->dev, sizeof(struct cpt_res_s),
  1170					 &res_iova, GFP_ATOMIC);
  1171		if (!res)
  1172			return -ENOMEM;
  1173	
  1174		sa_cptr = inb_ctx_info->sa_entry;
  1175		sa_iova = inb_ctx_info->sa_iova;
  1176		sa_size = sizeof(struct cn10k_rx_sa_s);
  1177	
  1178		sa_dptr = dma_alloc_coherent(pf->dev, sa_size, &dptr_iova, GFP_ATOMIC);
  1179		if (!sa_dptr) {
  1180			dma_free_coherent(pf->dev, sizeof(struct cpt_res_s), res,
  1181					  res_iova);
  1182			return -ENOMEM;
  1183		}
  1184	
  1185		for (off = 0; off < (sa_size / 8); off++)
  1186			*((u64 *)sa_dptr + off) = cpu_to_be64(*((u64 *)sa_cptr + off));
  1187	
  1188		memset(&inst, 0, sizeof(struct cpt_inst_s));
  1189	
  1190		res->compcode = 0;
  1191		inst.res_addr = res_iova;
  1192		inst.dptr = (u64)dptr_iova;
  1193		inst.param2 = sa_size >> 3;
  1194		inst.dlen = sa_size;
  1195		inst.opcode_major = CN10K_IPSEC_MAJOR_OP_WRITE_SA;
  1196		inst.opcode_minor = CN10K_IPSEC_MINOR_OP_WRITE_SA;
  1197		inst.cptr = sa_iova;
  1198		inst.ctx_val = 1;
  1199		inst.egrp = CN10K_DEF_CPT_IPSEC_EGRP;
  1200	
  1201		/* Re-use Outbound CPT LF to install Ingress SAs as well because
  1202		 * the driver does not own the ingress CPT LF.
  1203		 */
  1204		pf->ipsec.io_addr = (__force u64)otx2_get_regaddr(pf, CN10K_CPT_LF_NQX(0));
  1205		cn10k_cpt_inst_flush(pf, &inst, sizeof(struct cpt_inst_s));
> 1206		dmb(sy);
  1207	
  1208		ret = cn10k_wait_for_cpt_respose(pf, res);
  1209		if (ret)
  1210			goto out;
  1211	
  1212		/* Trigger CTX flush to write dirty data back to DRAM */
  1213		reg_val = FIELD_PREP(GENMASK_ULL(45, 0), sa_iova >> 7);
  1214		otx2_write64(pf, CN10K_CPT_LF_CTX_FLUSH, reg_val);
  1215	
  1216	out:
  1217		dma_free_coherent(pf->dev, sa_size, sa_dptr, dptr_iova);
  1218		dma_free_coherent(pf->dev, sizeof(struct cpt_res_s), res, res_iova);
  1219		return ret;
  1220	}
  1221	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ