netdev - Re: [PATCH net-next v2 8/8] selftests: drv-net: test RSS Netlink notifications

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD4GDZy-8RNgLvXcS6BmgvAiCW8iEtJCw8+B+1QDOM7gzkzgyA@mail.gmail.com>
Date: Wed, 25 Jun 2025 22:55:21 +0100
From: Donald Hunter <donald.hunter@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com, 
	pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org, 
	maxime.chevallier@...tlin.com, sdf@...ichev.me, jdamato@...tly.com, 
	ecree.xilinx@...il.com
Subject: Re: [PATCH net-next v2 8/8] selftests: drv-net: test RSS Netlink notifications

On Wed, 25 Jun 2025 at 21:04, Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Wed, 25 Jun 2025 10:46:53 +0100 Donald Hunter wrote:
> > > +def _ethtool_create(cfg, act, opts):
> > > +    output = ethtool(f"{act} {cfg.ifname} {opts}").stdout
> > > +    # Output will be something like: "New RSS context is 1" or
> > > +    # "Added rule with ID 7", we want the integer from the end
> > > +    return int(output.split()[-1])
> >
> > I think .split() is not required because you can access strings as
> > arrays.
> >
> > Will this only ever need to handle single digit values?
>
> nosir, IIUC split splits on whitespace, so from:
>
>         "Added rule with ID 7"  -> [.."ID", "7"]
>         "Added rule with ID 71" -> [.."ID", "71"]
>
> and we take the last elem, the ID. We use similar code in the rss_ctx
> test, I think it works..

Ah, my bad. Ignore my rambling and sorry for the noise.

> Unfortunately there is no plan to migrate the flow steering to netlink.
> And ethtool only supports JSON output in the netlink code :S
> Mountains of technical debt :)