netdev - Re: [PATCH net-next] ptp: add Alibaba CIPU PTP clock driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202506260725.kFmPHRIJ-lkp@intel.com>
Date: Thu, 26 Jun 2025 07:14:01 +0800
From: kernel test robot <lkp@...el.com>
To: Wen Gu <guwen@...ux.alibaba.com>, richardcochran@...il.com,
	andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	xuanzhuo@...ux.alibaba.com, dust.li@...ux.alibaba.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	guwen@...ux.alibaba.com
Subject: Re: [PATCH net-next] ptp: add Alibaba CIPU PTP clock driver

Hi Wen,

kernel test robot noticed the following build errors:

[auto build test ERROR on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Wen-Gu/ptp-add-Alibaba-CIPU-PTP-clock-driver/20250625-212835
base:   net-next/main
patch link:    https://lore.kernel.org/r/20250625132549.93614-1-guwen%40linux.alibaba.com
patch subject: [PATCH net-next] ptp: add Alibaba CIPU PTP clock driver
config: x86_64-buildonly-randconfig-002-20250626 (https://download.01.org/0day-ci/archive/20250626/202506260725.kFmPHRIJ-lkp@intel.com/config)
compiler: clang version 20.1.7 (https://github.com/llvm/llvm-project 6146a88f60492b520a36f8f8f3231e15f3cc6082)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250626/202506260725.kFmPHRIJ-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202506260725.kFmPHRIJ-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/ptp/ptp_cipu.c:775:8: error: call to undeclared function 'pci_request_irq'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     775 |                 rc = pci_request_irq(pdev, i, irq_ctx[i].irq_func, NULL,
         |                      ^
   drivers/ptp/ptp_cipu.c:775:8: note: did you mean 'pci_request_acs'?
   include/linux/pci.h:2570:6: note: 'pci_request_acs' declared here
    2570 | void pci_request_acs(void);
         |      ^
>> drivers/ptp/ptp_cipu.c:784:3: error: call to undeclared function 'pci_free_irq'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     784 |                 pci_free_irq(pdev, i, ptp_ctx);
         |                 ^
>> drivers/ptp/ptp_cipu.c:785:2: error: call to undeclared function 'pci_free_irq_vectors'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     785 |         pci_free_irq_vectors(pdev);
         |         ^
   drivers/ptp/ptp_cipu.c:785:2: note: did you mean 'pci_alloc_irq_vectors'?
   include/linux/pci.h:2139:1: note: 'pci_alloc_irq_vectors' declared here
    2139 | pci_alloc_irq_vectors(struct pci_dev *dev, unsigned int min_vecs,
         | ^
   drivers/ptp/ptp_cipu.c:796:3: error: call to undeclared function 'pci_free_irq'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     796 |                 pci_free_irq(pdev, i, ptp_ctx);
         |                 ^
   drivers/ptp/ptp_cipu.c:797:2: error: call to undeclared function 'pci_free_irq_vectors'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     797 |         pci_free_irq_vectors(pdev);
         |         ^
   5 errors generated.


vim +/pci_request_irq +775 drivers/ptp/ptp_cipu.c

   763	
   764	static int ptp_cipu_init_irq(struct ptp_cipu_ctx *ptp_ctx)
   765	{
   766		struct pci_dev *pdev = ptp_ctx->pdev;
   767		int i, rc;
   768	
   769		rc = pci_alloc_irq_vectors(pdev, PTP_CIPU_IRQ_NUM,
   770					   PTP_CIPU_IRQ_NUM, PCI_IRQ_MSIX);
   771		if (rc < 0)
   772			goto out;
   773	
   774		for (i = 0; i < PTP_CIPU_IRQ_NUM; i++) {
 > 775			rc = pci_request_irq(pdev, i, irq_ctx[i].irq_func, NULL,
   776					     ptp_ctx, "ptp-cipu");
   777			if (rc)
   778				goto out_vec;
   779		}
   780		return 0;
   781	
   782	out_vec:
   783		for (i = i - 1; i >= 0; i--)
 > 784			pci_free_irq(pdev, i, ptp_ctx);
 > 785		pci_free_irq_vectors(pdev);
   786	out:
   787		return rc;
   788	}
   789	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki