netdev - Re: [PATCH net] net: libwx: fix the creation of page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHS8izOCvLBWee3vp-Xv_XATztcTA2Rnu7CDtRfN+2CHo_cgww@mail.gmail.com>
Date: Wed, 25 Jun 2025 16:27:09 -0700
From: Mina Almasry <almasrymina@...gle.com>
To: Jiawen Wu <jiawenwu@...stnetic.com>
Cc: netdev@...r.kernel.org, andrew+netdev@...n.ch, davem@...emloft.net, 
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, horms@...nel.org, 
	mengyuanlou@...-swift.com, duanqiangwen@...-swift.com, stable@...r.kernel.org
Subject: Re: [PATCH net] net: libwx: fix the creation of page_pool

On Tue, Jun 24, 2025 at 7:41 PM Jiawen Wu <jiawenwu@...stnetic.com> wrote:
>
> 'rx_ring->size' means the count of ring descriptors multiplied by the
> size of one descriptor. When increasing the count of ring descriptors,
> it may exceed the limit of pool size.
>
> [ 864.209610] page_pool_create_percpu() gave up with errno -7
> [ 864.209613] txgbe 0000:11:00.0: Page pool creation failed: -7
>
> Fix to set the pool_size to the count of ring descriptors.
>
> Fixes: 850b971110b2 ("net: libwx: Allocate Rx and Tx resources")
> Cc: stable@...r.kernel.org
> Signed-off-by: Jiawen Wu <jiawenwu@...stnetic.com>

Looks correct to me. pool_size is meant to be the number of entries in
the ptr_ring indeed, not a size in bytes. wx_setup_rx_resources does
set up rx_ring->size to be the size in bytes based on the
rx_ring->count.

Reviewed-by: Mina Almasry <almasrymina@...gle.com>

-- 
Thanks,
Mina