netdev - Re: [PATCH net-next v2 3/8] net/mlx5: HWS, Refactor and export rule skip logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dff4ea02-4adc-4044-a18a-ee884abc0053@nvidia.com>
Date: Wed, 25 Jun 2025 03:35:52 +0300
From: Yevgeny Kliteynik <kliteyn@...dia.com>
To: Simon Horman <horms@...nel.org>, Mark Bloch <mbloch@...dia.com>
Cc: "David S. Miller" <davem@...emloft.net>, Jakub Kicinski
 <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Eric Dumazet <edumazet@...gle.com>, Andrew Lunn <andrew+netdev@...n.ch>,
 saeedm@...dia.com, gal@...dia.com, leonro@...dia.com, tariqt@...dia.com,
 Leon Romanovsky <leon@...nel.org>, netdev@...r.kernel.org,
 linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org, moshe@...dia.com,
 Vlad Dogaru <vdogaru@...dia.com>
Subject: Re: [PATCH net-next v2 3/8] net/mlx5: HWS, Refactor and export rule
 skip logic

Hi Simon,
Thanks for reviewing the patches!

On 24-Jun-25 21:38, Simon Horman wrote:
> On Sun, Jun 22, 2025 at 08:22:21PM +0300, Mark Bloch wrote:
>> From: Vlad Dogaru <vdogaru@...dia.com>
>>
>> The bwc layer will use `mlx5hws_rule_skip` to keep track of numbers of
>> RX and TX rules individually, so export this function for future usage.
>>
>> While we're in there, reduce nesting by adding a couple of early return
>> statements.
> 
> I'm all for reducing nesting. But this patch has two distinct changes.
> Please consider splitting it into two patches.

Not sure I'd send the refactor thing alone - it isn't worth the effort
IMHO... But since I'm already in here - sure, will sent it in a separate
patch.

>>
>> Signed-off-by: Vlad Dogaru <vdogaru@...dia.com>
>> Reviewed-by: Yevgeny Kliteynik <kliteyn@...dia.com>
>> Signed-off-by: Mark Bloch <mbloch@...dia.com>
> 
> ...