netdev - Re: [net-next v7 1/3] net: bonding: add broadcast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <0448275B-F4B3-43F1-BB27-CF8DAEDAA28F@bamaicloud.com>
Date: Thu, 26 Jun 2025 19:16:40 +0800
From: Tonghao Zhang <tonghao@...aicloud.com>
To: Paolo Abeni <pabeni@...hat.com>
Cc: netdev@...r.kernel.org,
 Jay Vosburgh <jv@...sburgh.net>,
 "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>,
 Simon Horman <horms@...nel.org>,
 Jonathan Corbet <corbet@....net>,
 Andrew Lunn <andrew+netdev@...n.ch>,
 Steven Rostedt <rostedt@...dmis.org>,
 Masami Hiramatsu <mhiramat@...nel.org>,
 Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
 Nikolay Aleksandrov <razor@...ckwall.org>,
 Zengbing Tu <tuzengbing@...iglobal.com>
Subject: Re: [net-next v7 1/3] net: bonding: add broadcast_neighbor option for
 802.3ad

> 2025年6月26日 18:49，Paolo Abeni <pabeni@...hat.com> 写道：
> 
> On 6/24/25 4:18 AM, Tonghao Zhang wrote:
>> @@ -893,6 +909,8 @@ static int bond_option_mode_set(struct bonding *bond,
>> /* don't cache arp_validate between modes */
>> bond->params.arp_validate = BOND_ARP_VALIDATE_NONE;
>> bond->params.mode = newval->value;
>> + /* cleanup broadcast_neighbor when changing mode */
>> + bond->params.broadcast_neighbor = 0;
> 
> This does not look enough: it looks like 'bond_bcast_neigh_enabled'
> accounting is ignored, and should instead adjusted accordingly.
I try to explain, setting the bonding mode requires putting the device in the down state, which has already reduced this value, so do not reduce the value again in this function.
> 
> Side notes: please include per patch changelog to help reviewers, and
> when replying to reviewers comment, please properly trim the unrelevant
> message part and separate your text from the quoted one.
Ok
> 
> Thanks,
> 
> Paolo
> 
>