netdev - Re: [PATCH net 01/10] netlink: specs: nfsd: replace underscores with dashes in names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ce04ba52-9201-4594-9079-64000e8dc797@oracle.com>
Date: Thu, 26 Jun 2025 08:58:41 -0400
From: Chuck Lever <chuck.lever@...cle.com>
To: Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net,
        donald.hunter@...il.com
Cc: netdev@...r.kernel.org, edumazet@...gle.com, pabeni@...hat.com,
        andrew+netdev@...n.ch, horms@...nel.org, jlayton@...nel.org,
        lorenzo@...nel.org
Subject: Re: [PATCH net 01/10] netlink: specs: nfsd: replace underscores with
 dashes in names

On 6/24/25 5:09 PM, Jakub Kicinski wrote:
> We're trying to add a strict regexp for the name format in the spec.
> Underscores will not be allowed, dashes should be used instead.
> This makes no difference to C (codegen, if used, replaces special
> chars in names) but it gives more uniform naming in Python.
> 
> Fixes: 13727f85b49b ("NFSD: introduce netlink stubs")
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> CC: donald.hunter@...il.com
> CC: chuck.lever@...cle.com
> CC: jlayton@...nel.org
> CC: lorenzo@...nel.org
> ---
>  Documentation/netlink/specs/nfsd.yaml | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/netlink/specs/nfsd.yaml b/Documentation/netlink/specs/nfsd.yaml
> index c87658114852..8d1a3c01708f 100644
> --- a/Documentation/netlink/specs/nfsd.yaml
> +++ b/Documentation/netlink/specs/nfsd.yaml
> @@ -27,7 +27,7 @@ doc: NFSD configuration over generic netlink.
>          name: proc
>          type: u32
>        -
> -        name: service_time
> +        name: service-time
>          type: s64
>        -
>          name: pad
> @@ -139,7 +139,7 @@ doc: NFSD configuration over generic netlink.
>              - prog
>              - version
>              - proc
> -            - service_time
> +            - service-time
>              - saddr4
>              - daddr4
>              - saddr6

Reviewed-by: Chuck Lever <chuck.lever@...cle.com>


-- 
Chuck Lever