netdev - net: openvswitch: incorrect usage in ovs_meters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <6B26C96C-1941-4AFF-AEAC-6C7E36CDFF02@163.com>
Date: Thu, 26 Jun 2025 20:59:52 +0800
From: lihuawei <lihuawei_zzu@....com>
To: pshelar@....org,
 davem@...emloft.net,
 edumazet@...gle.com,
 kuba@...nel.org,
 pabeni@...hat.com,
 xiangxia.m.yue@...il.com,
 netdev@...r.kernel.org
Subject: net: openvswitch: incorrect usage in ovs_meters_exit?

hi, guys,

	Recently, I am working on ovs meter.c, after reading the code, I have two questions about the ovs_meters_exit function as bellow :

void ovs_meters_exit(struct datapath *dp)
{
	struct dp_meter_table *tbl = &dp->meter_tbl;
	struct dp_meter_instance *ti = rcu_dereference_raw(tbl->ti);
	int i;

	for (i = 0; i < ti->n_meters; i++)
		ovs_meter_free(rcu_dereference_raw(ti->dp_meters[i]));

	dp_meter_instance_free(ti);
}

    1. why use rcu_dereference_raw here and not rcu_dereference_ovsl?
    2. why use dp_meter_instance_free here and not dp_meter_instance_free_rcu?

Best Regards, 
Huawei Li