netdev - Re: [PATCH net-next v2 2/4] selftests: drv-net: Improve bpftrace utility error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aF1HCmA0KHG/Gb62@gmail.com>
Date: Thu, 26 Jun 2025 06:11:38 -0700
From: Breno Leitao <leitao@...ian.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
	Shuah Khan <shuah@...nel.org>, Simon Horman <horms@...nel.org>,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	linux-kselftest@...r.kernel.org,
	Willem de Bruijn <willemdebruijn.kernel@...il.com>,
	bpf@...r.kernel.org, gustavold@...il.com
Subject: Re: [PATCH net-next v2 2/4] selftests: drv-net: Improve bpftrace
 utility error handling

On Wed, Jun 25, 2025 at 02:48:16PM -0700, Jakub Kicinski wrote:
> On Wed, 25 Jun 2025 04:39:47 -0700 Breno Leitao wrote:
> >      cmd_obj = cmd(cmd_arr, ns=ns, host=host, shell=False)
> > +    if cmd_obj.ret != 0:
> > +        raise Exception("Warning: bpftrace command returned a non-zero exit code.")
> 
> cmd should already raise CmdExitFailure, unless fail=False / fail=None
> is specified.

Oh yea, even easier. I found the code, and it is much easier to just set
fail=True for this case. This will avoid hidden errors.