netdev - Re: [PATCH v2 net-next 00/15] ipv6: Drop RTNL from mcast.c and anycast.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6c33dd3e-373a-41b3-b67a-1b89ce1ab1b5@redhat.com>
Date: Thu, 26 Jun 2025 15:27:30 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Kuniyuki Iwashima <kuni1840@...il.com>,
 "David S. Miller" <davem@...emloft.net>, David Ahern <dsahern@...nel.org>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>
Cc: Simon Horman <horms@...nel.org>, Kuniyuki Iwashima <kuniyu@...gle.com>,
 netdev@...r.kernel.org
Subject: Re: [PATCH v2 net-next 00/15] ipv6: Drop RTNL from mcast.c and
 anycast.c

On 6/24/25 10:24 PM, Kuniyuki Iwashima wrote:
> From: Kuniyuki Iwashima <kuniyu@...gle.com>
> 
> This is a prep series for RCU conversion of RTM_NEWNEIGH, which needs
> RTNL during neigh_table.{pconstructor,pdestructor}() touching IPv6
> multicast code.
> 
> Currently, IPv6 multicast code is protected by lock_sock() and
> inet6_dev->mc_lock, and RTNL is not actually needed.
> 
> In addition, anycast code is also in the same situation and does not
> need RTNL at all.
> 
> This series removes RTNL from net/ipv6/{mcast.c,anycast.c} and finally
> removes setsockopt_needs_rtnl() from do_ipv6_setsockopt().

I went through the whole series I could not find any obvious bug.

Still this is not trivial matter and I recently missed bugs in similar
changes, so let me keep the series in PW for a little longer, just in
case some other pair of eyes would go over it ;)

BTW @Kuniyuki: do you have a somewhat public todo list that others could
peek at to join this effort?

Thanks!

Paolo