netdev - Re: [PATCH v2 02/17] psp: base PSP device support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250626070047.6567609c@kernel.org>
Date: Thu, 26 Jun 2025 07:00:47 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Willem de Bruijn <willemdebruijn.kernel@...il.com>
Cc: Daniel Zahka <daniel.zahka@...il.com>, Donald Hunter
 <donald.hunter@...il.com>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Simon
 Horman <horms@...nel.org>, Jonathan Corbet <corbet@....net>, Andrew Lunn
 <andrew+netdev@...n.ch>, Saeed Mahameed <saeedm@...dia.com>, Leon
 Romanovsky <leon@...nel.org>, Tariq Toukan <tariqt@...dia.com>, Boris
 Pismenny <borisp@...dia.com>, Kuniyuki Iwashima <kuniyu@...gle.com>, Willem
 de Bruijn <willemb@...gle.com>, David Ahern <dsahern@...nel.org>, Neal
 Cardwell <ncardwell@...gle.com>, Patrisious Haddad <phaddad@...dia.com>,
 Raed Salem <raeds@...dia.com>, Jianbo Liu <jianbol@...dia.com>, Dragos
 Tatulea <dtatulea@...dia.com>, Rahul Rameshbabu <rrameshbabu@...dia.com>,
 Stanislav Fomichev <sdf@...ichev.me>, Toke Høiland-Jørgensen <toke@...hat.com>, Alexander Lobakin
 <aleksander.lobakin@...el.com>, Jacob Keller <jacob.e.keller@...el.com>,
 netdev@...r.kernel.org
Subject: Re: [PATCH v2 02/17] psp: base PSP device support

On Wed, 25 Jun 2025 19:55:01 -0400 Willem de Bruijn wrote:
> > +#define PSP_SPI_KEY_ID		GENMASK(30, 0)
> > +#define PSP_SPI_KEY_PHASE	BIT(31)
> > +
> > +#define PSPHDR_CRYPT_OFFSET	GENMASK(5, 0)
> > +
> > +#define PSPHDR_VERFL_SAMPLE	BIT(7)
> > +#define PSPHDR_VERFL_DROP	BIT(6)
> > +#define PSPHDR_VERFL_VERSION	GENMASK(5, 2)
> > +#define PSPHDR_VERFL_VIRT	BIT(1)
> > +#define PSPHDR_VERFL_ONE	BIT(0)  
> 
> Use bitfields in struct psphdr rather than manual bit twiddling?

Some call it manual bit twiddling, some call it the recommended kernel
coding style? ;)

> Or else just consider just calling it flags rather than verfl
> (which stands for version and flags?).

(Yes.)

> > +
> > +/**
> > + * struct psp_dev_config - PSP device configuration
> > + * @versions: PSP versions enabled on the device
> > + */
> > +struct psp_dev_config {
> > +	u32 versions;
> > +};
> > +
> > +/**
> > + * struct psp_dev - PSP device struct
> > + * @main_netdev: original netdevice of this PSP device  
> 
> This makes sense with a single physical device plus optional virtual
> (vlan, bonding, ..) devices.
> 
> It may also be possible for a single physical device (with single
> device key) to present multiple PFs and/or VFs. In that case, will
> there be multiple struct psp_dev, or will one PF be the "main".

AFAIU we have no ability to represent multi-PCIe function devices 
in the kernel model today. So realistically I think psp_dev per
function and then propagate the rotation events.