netdev - Re: [PATCH v2 net-next 02/15] ipv6: mcast: Replace locking comments with lockdep annotations.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iKHeB2_+oBD0evw-xPXbQtdGtUiUmTQFsMPnFk9WQAAnQ@mail.gmail.com>
Date: Thu, 26 Jun 2025 07:28:45 -0700
From: Eric Dumazet <edumazet@...gle.com>
To: Kuniyuki Iwashima <kuni1840@...il.com>
Cc: "David S. Miller" <davem@...emloft.net>, David Ahern <dsahern@...nel.org>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, 
	Kuniyuki Iwashima <kuniyu@...gle.com>, netdev@...r.kernel.org
Subject: Re: [PATCH v2 net-next 02/15] ipv6: mcast: Replace locking comments
 with lockdep annotations.

On Tue, Jun 24, 2025 at 1:26 PM Kuniyuki Iwashima <kuni1840@...il.com> wrote:
>
> From: Kuniyuki Iwashima <kuniyu@...gle.com>
>
> Commit 63ed8de4be81 ("mld: add mc_lock for protecting per-interface
> mld data") added the same comments regarding locking to many functions.
>
> Let's replace the comments with lockdep annotation, which is more helpful.
>
> Note that we just remove the comment for mld_clear_zeros() and
> mld_send_cr(), where mc_dereference() is used in the entry of the
> function.
>
> While at it, a comment for __ipv6_sock_mc_join() is moved back to the
> correct place.
>
> Signed-off-by: Kuniyuki Iwashima <kuniyu@...gle.com>

Reviewed-by: Eric Dumazet <edumazet@...gle.com>