netdev - Re: [PATCH v2 net-next 04/15] ipv6: mcast: Remove mca

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iJ6H5BYDzv2d26-u5W=GU7stN4YJQUZwVhaD5fNcA6=Tw@mail.gmail.com>
Date: Thu, 26 Jun 2025 07:31:59 -0700
From: Eric Dumazet <edumazet@...gle.com>
To: Kuniyuki Iwashima <kuni1840@...il.com>
Cc: "David S. Miller" <davem@...emloft.net>, David Ahern <dsahern@...nel.org>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, 
	Kuniyuki Iwashima <kuniyu@...gle.com>, netdev@...r.kernel.org
Subject: Re: [PATCH v2 net-next 04/15] ipv6: mcast: Remove mca_get().

On Tue, Jun 24, 2025 at 1:26 PM Kuniyuki Iwashima <kuni1840@...il.com> wrote:
>
> From: Kuniyuki Iwashima <kuniyu@...gle.com>
>
> Since commit 63ed8de4be81 ("mld: add mc_lock for protecting per-interface
> mld data"), the newly allocated struct ifmcaddr6 cannot be removed until
> inet6_dev->mc_lock is released, so mca_get() and mc_put() are unnecessary.
>
> Let's remove the extra refcounting.
>
> Note that mca_get() was only used in __ipv6_dev_mc_inc().
>
> Signed-off-by: Kuniyuki Iwashima <kuniyu@...gle.com>

Reviewed-by: Eric Dumazet <edumazet@...gle.com>