netdev - Re: [PATCH v2 net-next 11/15] ipv6: anycast: Don't use rtnl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iLs3iGM6E0GummYY2ZoQgqEbAamO6=ff1wk54GgodCX+w@mail.gmail.com>
Date: Thu, 26 Jun 2025 07:46:14 -0700
From: Eric Dumazet <edumazet@...gle.com>
To: Kuniyuki Iwashima <kuni1840@...il.com>
Cc: "David S. Miller" <davem@...emloft.net>, David Ahern <dsahern@...nel.org>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, 
	Kuniyuki Iwashima <kuniyu@...gle.com>, netdev@...r.kernel.org
Subject: Re: [PATCH v2 net-next 11/15] ipv6: anycast: Don't use rtnl_dereference().

On Tue, Jun 24, 2025 at 1:26 PM Kuniyuki Iwashima <kuni1840@...il.com> wrote:
>
> From: Kuniyuki Iwashima <kuniyu@...gle.com>
>
> inet6_dev->ac_list is protected by inet6_dev->lock, so rtnl_dereference()
> is a bit rough annotation.
>
> As done in mcast.c, we can use ac_dereference() that checks if
> inet6_dev->lock is held.
>
> Let's replace rtnl_dereference() with a new helper ac_dereference().
>
> Note that now addrconf_join_solict() / addrconf_leave_solict() in
> __ipv6_dev_ac_inc() / __ipv6_dev_ac_dec() does not need RTNL, so we
> can remove ASSERT_RTNL() there.
>
> Signed-off-by: Kuniyuki Iwashima <kuniyu@...gle.com>

Reviewed-by: Eric Dumazet <edumazet@...gle.com>