netdev - Re: [net-next PATCH] octeontx2-pf: Check for DMAC extraction before setting VF DMAC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aFznYtDq9ywfk5FJ@822c91e11a5c>
Date: Thu, 26 Jun 2025 06:23:30 +0000
From: Subbaraya Sundeep <sbhatta@...vell.com>
To: Simon Horman <horms@...nel.org>
CC: <andrew+netdev@...n.ch>, <davem@...emloft.net>, <edumazet@...gle.com>,
        <kuba@...nel.org>, <pabeni@...hat.com>, <sgoutham@...vell.com>,
        <gakula@...vell.com>, <hkelam@...vell.com>, <bbhushan2@...vell.com>,
        <netdev@...r.kernel.org>, Suman Ghosh <sumang@...vell.com>
Subject: Re: [net-next PATCH] octeontx2-pf: Check for DMAC extraction before
 setting VF DMAC

On 2025-06-25 at 19:02:47, Simon Horman (horms@...nel.org) wrote:
> On Wed, Jun 25, 2025 at 05:00:02PM +0530, Subbaraya Sundeep wrote:
> > From: Suman Ghosh <sumang@...vell.com>
> > 
> > Currently while setting a MAC address of a PF's VF (e.g. ip link set
> > <pf-netdev> vf 0 mac <mac-address>), it simply tries to install a DMAC
> > based hardware filter. But it is possible that the loaded hardware parser
> > profile does not support DMAC extraction. Hence check for DMAC extraction
> > before installing the filter.
> 
> Makes sense to me, but should this be treated as a bug fix?
> 
No strong opinion on whether this is a bug fix or not.
We assumed DMAC is required always until on of our customers
came up with profile with no DMAC extraction so that they can
use the additional MCAM space created for other packet fields.
I will send as bug fix if you insist.

Thanks,
Sundeep
> > 
> > Signed-off-by: Suman Ghosh <sumang@...vell.com>
> > Signed-off-by: Subbaraya Sundeep <sbhatta@...vell.com>
> 
> ...