netdev - Re: [PATCH net-next v3 3/3] net: phy: bcm54811: Fix the PHY initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e0105ca9-4903-4b47-b6f4-76f1e3da65d5@axis.com>
Date: Thu, 26 Jun 2025 09:37:45 +0200
From: Kamil Horák (2N) <kamilh@...s.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next v3 3/3] net: phy: bcm54811: Fix the PHY
 initialization



On 6/25/25 18:49, Andrew Lunn wrote:
> On Wed, Jun 25, 2025 at 06:34:53PM +0200, Kamil Horák - 2N wrote:
>> From: Kamil Horák (2N) <kamilh@...s.com>
>>
>> Reset the bit 12 in PHY's LRE Control register upon initialization.
>> According to the datasheet, this bit must be written to zero after
>> every device reset.
> 
> This actually sounds like a fix. Why are not you adding a Fixes: tag
> and posting it for net, not net-next?
Yes at least the patch with bcm54811 initialization is rather a fix, but 
the rest (MII-Lite phy interface mode) could be also considered adding 
support for this Broadcom-specific phy interface mode for bcm54810.
The bcm54811 is likely only available in MLP case, which means MII-Lite 
only and from this point of view, adding support of MII-Lite is a fix too.
So if it does not matter that we are adding support for non-standard phy 
interface mode including its effects also valid for non-Broadcom PHYS 
(full-duplex link modes only), I'll submit it as a fix to net, instead 
than doing it here.

Kamil
> 
> 	Andrew