Message-ID: <20250627112234.1cb54133@2a02-8440-d103-6715-ef68-2a2e-b947-8885.rev.sfr.net>
Date: Fri, 27 Jun 2025 11:41:51 +0200
From: Maxime Chevallier <maxime.chevallier@...tlin.com>
To: Théo Lebrun <theo.lebrun@...tlin.com>
Cc: Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
 <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Rob Herring
 <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Nicolas Ferre <nicolas.ferre@...rochip.com>, Claudiu
 Beznea <claudiu.beznea@...on.dev>, Paul Walmsley
 <paul.walmsley@...ive.com>, Palmer Dabbelt <palmer@...belt.com>, Albert Ou
 <aou@...s.berkeley.edu>, Alexandre Ghiti <alex@...ti.fr>, Samuel Holland
 <samuel.holland@...ive.com>, Richard Cochran <richardcochran@...il.com>,
 Russell King <linux@...linux.org.uk>, Thomas Bogendoerfer
 <tsbogend@...ha.franken.de>, Vladimir Kondratiev
 <vladimir.kondratiev@...ileye.com>, Gregory CLEMENT
 <gregory.clement@...tlin.com>, Cyrille Pitchen <cyrille.pitchen@...el.com>,
 Harini Katakam <harini.katakam@...inx.com>, Rafal Ozieblo
 <rafalo@...ence.com>, Haavard Skinnemoen <hskinnemoen@...el.com>,
 netdev@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org,
 linux-mips@...r.kernel.org, Thomas Petazzoni
 <thomas.petazzoni@...tlin.com>, Tawfik Bayouk <tawfik.bayouk@...ileye.com>,
 Andrew Lunn <andrew@...n.ch>
Subject: Re: [PATCH net-next v2 00/18] Support the Cadence MACB/GEM
 instances on Mobileye EyeQ5 SoCs

Hi Théo,

On Fri, 27 Jun 2025 11:08:46 +0200
Théo Lebrun <theo.lebrun@...tlin.com> wrote:

> Mobileye EyeQ5 SoCs provides two GEM IP blocks. The end result of this
> series is working 1G networking on the EyeQ5 eval board. It isn't just
> a new macb_config & compatible, we also provide some cleanup & fixes
> along the way.
> 
> dt-bindings:
>   [PATCH net-next v2 01/18] dt-bindings: net: cdns,macb: sort compatibles
>   [PATCH net-next v2 02/18] dt-bindings: net: cdns,macb: add Mobileye EyeQ5 ethernet interface
>   [PATCH net-next v2 03/18] dt-bindings: net: cdns,macb: allow tsu_clk without tx_clk
>   [PATCH net-next v2 04/18] dt-bindings: net: cdns,macb: allow dma-coherent
> 
> Cleanup:
>   [PATCH net-next v2 05/18] net: macb: use BIT() macro for capability definitions
>   [PATCH net-next v2 06/18] net: macb: Remove local variables clk_init and init in macb_probe()
>   [PATCH net-next v2 07/18] net: macb: drop macb_config NULL checking
>   [PATCH net-next v2 08/18] net: macb: introduce DMA descriptor helpers (is 64bit? is PTP?)
>   [PATCH net-next v2 09/18] net: macb: sort #includes
> 
> Fixes:
>   [PATCH net-next v2 10/18] net: macb: remove illusion about TBQPH/RBQPH being per-queue
>   [PATCH net-next v2 11/18] net: macb: single dma_alloc_coherent() for DMA descriptors
>   [PATCH net-next v2 12/18] net: macb: match skb_reserve(skb, NET_IP_ALIGN) with HW alignment
>   [PATCH net-next v2 13/18] net: macb: avoid double endianness swap in macb_set_hwaddr()

Fixes go through the net tree, and new features through net-next :

https://docs.kernel.org/process/maintainer-netdev.html#netdev-faq

As this series is quite big, it could be nice to send the cleanups and
fixes in dedicated series, and then the eyeQ5 support in itself as a
standalone series. This would make the review work easier.


> EyeQ5 support:
>   [PATCH net-next v2 14/18] net: macb: add no LSO capability (MACB_CAPS_NO_LSO)
>   [PATCH net-next v2 15/18] net: macb: Add "mobileye,eyeq5-gem" compatible
> 
> DTS:
>   [PATCH net-next v2 16/18] MIPS: mobileye: add EyeQ5 DMA IOCU support
>   [PATCH net-next v2 17/18] MIPS: mobileye: eyeq5: add two Cadence GEM Ethernet controllers
>   [PATCH net-next v2 18/18] MIPS: mobileye: eyeq5-epm: add two Cadence GEM Ethernet PHYs

Maxime

Powered by blists - more mailing lists