netdev - Re: [PATCH v15 5/9] ref_tracker: allow pr_ostream() to print directly to a seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <gzivdr6uvr4fps7uu2wl7ti63lnevmlekww6lbqfvyp4crm424@srxb7pzsj3fi>
Date: Fri, 27 Jun 2025 12:32:13 +0000
From: Krzysztof Karas <krzysztof.karas@...el.com>
To: Jeff Layton <jlayton@...nel.org>
CC: Andrew Morton <akpm@...ux-foundation.org>, "David S. Miller"
	<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Simon Horman
	<horms@...nel.org>, Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
	Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
	David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, "Jani
 Nikula" <jani.nikula@...ux.intel.com>, Joonas Lahtinen
	<joonas.lahtinen@...ux.intel.com>, Rodrigo Vivi <rodrigo.vivi@...el.com>,
	Tvrtko Ursulin <tursulin@...ulin.net>, Kuniyuki Iwashima <kuniyu@...zon.com>,
	Qasim Ijaz <qasdev00@...il.com>, Nathan Chancellor <nathan@...nel.org>,
	Andrew Lunn <andrew@...n.ch>, <linux-kernel@...r.kernel.org>,
	<netdev@...r.kernel.org>, <dri-devel@...ts.freedesktop.org>,
	<intel-gfx@...ts.freedesktop.org>
Subject: Re: [PATCH v15 5/9] ref_tracker: allow pr_ostream() to print
 directly to a seq_file

Hi Jeff,

> On Mon, 2025-06-23 at 14:01 +0000, Krzysztof Karas wrote:
> > Hi Jeff,
> > 
> > [...]
> > > +static __maybe_unused int
> > > +ref_tracker_dir_seq_print(struct ref_tracker_dir *dir, struct seq_file *seq)
> > > +{
> > > +	struct ostream os = { .func = pr_ostream_seq,
> > > +			      .prefix = "",
> > This is also a "ref_tracker_*" function, so maybe use the same
> > prefix as in other functions? I mean .prefix = "ref_tracker:".
> > Unless, you have a reason for leaving it empty ;)
> > 
> 
> I have a reason to leave it empty.
> 
> That is the prefix for each line that gets printed by the pr_ostream()
> call. This one is for the lines that go to the debugfs files. I think
> it will be redundant to prepend every line in these files with
> "ref_tracker: ".

OK, this makes sense.
Reviewed-by: Krzysztof Karas <krzysztof.karas@...el.com>

---
Best Regards,
Krzysztof