netdev - Re: [PATCH net-next v2 7/9] net/smc: Drop nr_pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250627125933.GE10186@linux.alibaba.com>
Date: Fri, 27 Jun 2025 20:59:33 +0800
From: Dust Li <dust.li@...ux.alibaba.com>
To: Michal Luczaj <mhal@...x.co>, "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Simon Horman <horms@...nel.org>,
	Neal Cardwell <ncardwell@...gle.com>,
	Kuniyuki Iwashima <kuniyu@...gle.com>,
	David Ahern <dsahern@...nel.org>,
	Boris Pismenny <borisp@...dia.com>,
	John Fastabend <john.fastabend@...il.com>,
	Ayush Sawal <ayush.sawal@...lsio.com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	Wenjia Zhang <wenjia@...ux.ibm.com>,
	Jan Karcher <jaka@...ux.ibm.com>,
	"D. Wythe" <alibuda@...ux.alibaba.com>,
	Tony Lu <tonylu@...ux.alibaba.com>,
	Wen Gu <guwen@...ux.alibaba.com>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-rdma@...r.kernel.org, linux-s390@...r.kernel.org
Subject: Re: [PATCH net-next v2 7/9] net/smc: Drop nr_pages_max initialization

On 2025-06-26 10:33:40, Michal Luczaj wrote:
>splice_pipe_desc::nr_pages_max was initialized unnecessarily in
>commit b8d199451c99 ("net/smc: Allow virtually contiguous sndbufs or RMBs
>for SMC-R"). Struct's field is unused in this context.
>
>Remove the assignment. No functional change intended.
>
>Suggested-by: Simon Horman <horms@...nel.org>
>Signed-off-by: Michal Luczaj <mhal@...x.co>

Reviewed-by: Dust Li <dust.li@...ux.alibaba.com>

>---
> net/smc/smc_rx.c | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/net/smc/smc_rx.c b/net/smc/smc_rx.c
>index e7f1134453ef40dd81a9574d6df4ead95acd8ae5..bbba5d4dc7eb0dbb31a9800023b0caab33e87842 100644
>--- a/net/smc/smc_rx.c
>+++ b/net/smc/smc_rx.c
>@@ -202,7 +202,6 @@ static int smc_rx_splice(struct pipe_inode_info *pipe, char *src, size_t len,
> 			offset = 0;
> 		}
> 	}
>-	spd.nr_pages_max = nr_pages;
> 	spd.nr_pages = nr_pages;
> 	spd.pages = pages;
> 	spd.partial = partial;
>
>-- 
>2.49.0
>