netdev - Re: [patch V3 01/11] timekeeping: Update auxiliary timekeepers on clocksource change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87o6u9nuv7.ffs@tglx>
Date: Fri, 27 Jun 2025 16:04:44 +0200
From: Thomas Gleixner <tglx@...utronix.de>
To: John Stultz <jstultz@...gle.com>
Cc: LKML <linux-kernel@...r.kernel.org>, netdev@...r.kernel.org, Richard
 Cochran <richardcochran@...il.com>, Christopher Hall
 <christopher.s.hall@...el.com>, Frederic Weisbecker <frederic@...nel.org>,
 Anna-Maria Behnsen <anna-maria@...utronix.de>, Miroslav Lichvar
 <mlichvar@...hat.com>, Werner Abt <werner.abt@...nberg-usa.com>, David
 Woodhouse <dwmw2@...radead.org>, Stephen Boyd <sboyd@...nel.org>, Thomas
 Weißschuh <thomas.weissschuh@...utronix.de>, Kurt
 Kanzenbach
 <kurt@...utronix.de>, Nam Cao <namcao@...utronix.de>, Antoine Tenart
 <atenart@...nel.org>
Subject: Re: [patch V3 01/11] timekeeping: Update auxiliary timekeepers on
 clocksource change

On Thu, Jun 26 2025 at 21:43, John Stultz wrote:
>> +/* Bitmap for the activated auxiliary timekeepers */
>> +static unsigned long aux_timekeepers;
>> +
>
> Nit: Would it be useful to clarify this is accessed without locks, and
> the related tks->clock_valid *must* be checked while holding the lock
> before using a timekeeper that is considered activated in the
> aux_timekeepers bitmap?

I'll amend all your nits when applying the pile.

Thanks,

        tglx