netdev - Re: [PATCH v2 02/17] psp: base PSP device support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <685ec277b82b2_4f1ca2948d@willemb.c.googlers.com.notmuch>
Date: Fri, 27 Jun 2025 12:10:31 -0400
From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
To: Jakub Kicinski <kuba@...nel.org>, 
 Willem de Bruijn <willemdebruijn.kernel@...il.com>
Cc: Daniel Zahka <daniel.zahka@...il.com>, 
 Donald Hunter <donald.hunter@...il.com>, 
 "David S. Miller" <davem@...emloft.net>, 
 Eric Dumazet <edumazet@...gle.com>, 
 Paolo Abeni <pabeni@...hat.com>, 
 Simon Horman <horms@...nel.org>, 
 Jonathan Corbet <corbet@....net>, 
 Andrew Lunn <andrew+netdev@...n.ch>, 
 Saeed Mahameed <saeedm@...dia.com>, 
 Leon Romanovsky <leon@...nel.org>, 
 Tariq Toukan <tariqt@...dia.com>, 
 Boris Pismenny <borisp@...dia.com>, 
 Kuniyuki Iwashima <kuniyu@...gle.com>, 
 Willem de Bruijn <willemb@...gle.com>, 
 David Ahern <dsahern@...nel.org>, 
 Neal Cardwell <ncardwell@...gle.com>, 
 Patrisious Haddad <phaddad@...dia.com>, 
 Raed Salem <raeds@...dia.com>, 
 Jianbo Liu <jianbol@...dia.com>, 
 Dragos Tatulea <dtatulea@...dia.com>, 
 Rahul Rameshbabu <rrameshbabu@...dia.com>, 
 Stanislav Fomichev <sdf@...ichev.me>, 
 Toke Høiland-Jørgensen <toke@...hat.com>, 
 Alexander Lobakin <aleksander.lobakin@...el.com>, 
 Jacob Keller <jacob.e.keller@...el.com>, 
 netdev@...r.kernel.org
Subject: Re: [PATCH v2 02/17] psp: base PSP device support

Jakub Kicinski wrote:
> On Thu, 26 Jun 2025 13:20:45 -0400 Willem de Bruijn wrote:
> > > > IDPF does support multiple "vports" (num_alloc_vports), and with that
> > > > struct net_device, from a single BDF.  
> > > 
> > > Upstream? If yes then I'm very bad at reviewing code :D  
> > 
> > I then don't think I want to focus your attention on this, but..
> > 
> > See use num_alloc_ports in idpf_init_task. Which keeps requeueing
> > itself until num_default_vports is reached. Which is a variable
> > received from the device in VIRTCHNL2_OP_GET_CAPS.
> 
> That's not too bad, one of the older drivers had a sysfs interface
> for creating the sub-interfaces IIRC :/
> 
> We should be able to share one psp_dev if the implementation shares PSP
> between blocks.

Great.

> I was trying to write the code so that it'd be possible
> to attach the psp_dev to veth / netkit
> IIRC the main_netdev was supposed to be special in terms of
> permissions, the admin in the netns where main_netdev sits is
> the admin of the device (for rotations and config).
> But I was planning to add a secondary list of "attached devices"
> which have access to non-privileged operations. 

That makes sense. I like how this approach enables support for such
devices without having to explicitly pipe through net_device_ops
(what legacy Google PSP implementation had to do for each of ipvlan,
bonding, etc).