netdev - Re: [PATCH net-next] net: net->nsid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAVpQUDv_DApOnqOR+Psu7Ykfd27am-xfEhfFjwYfRg5qSbrjg@mail.gmail.com>
Date: Fri, 27 Jun 2025 14:11:12 -0700
From: Kuniyuki Iwashima <kuniyu@...gle.com>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, netdev@...r.kernel.org, 
	eric.dumazet@...il.com, Guillaume Nault <gnault@...hat.com>, 
	Cong Wang <xiyou.wangcong@...il.com>
Subject: Re: [PATCH net-next] net: net->nsid_lock does not need BH safety

On Fri, Jun 27, 2025 at 9:32 AM Eric Dumazet <edumazet@...gle.com> wrote:
>
> At the time of commit bc51dddf98c9 ("netns: avoid disabling irq
> for netns id") peernet2id() was not yet using RCU.
>
> Commit 2dce224f469f ("netns: protect netns
> ID lookups with RCU") changed peernet2id() to no longer
> acquire net->nsid_lock (potentially from BH context).
>
> We do not need to block soft interrupts when acquiring
> net->nsid_lock anymore.
>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Reviewed-by: Kuniyuki Iwashima <kuniyu@...gle.com>