netdev - Re: [PATCH] net: tulip: Rename PCI driver struct to end in

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <23bh2e4lsts7wf7sjk5mgpwuzny3vzr7dau6aetgmhzcqnivr6@adsr6srfeyz5>
Date: Fri, 27 Jun 2025 23:22:23 +0200
From: Uwe Kleine-König <u.kleine-koenig@...libre.com>
To: Simon Horman <horms@...nel.org>
Cc: Andrew Lunn <andrew+netdev@...n.ch>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org, 
	linux-parisc@...r.kernel.org
Subject: Re: [PATCH] net: tulip: Rename PCI driver struct to end in _driver

On Fri, Jun 27, 2025 at 08:48:26PM +0100, Simon Horman wrote:
> On Fri, Jun 27, 2025 at 12:22:20PM +0200, Uwe Kleine-König wrote:
> > This is not only a cosmetic change because the section mismatch checks
> > also depend on the name and for drivers the checks are stricter than for
> > ops.
> > 
> > However xircom_driver also passes the stricter checks just fine, so no
> > further changes needed.
> > 
> > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...libre.com>
> 
> As per my comment on a similar patch for a different driver:
> 
> From a Networking subsystem point of view
> this feels more like an enhancement than a bug fix.
> Can we drop the Fixes tag?

For completeness: Here the same applies as for said other patch: IMHO
the Fixes: line is right, but I agree that we don't need a backport to
stable and I'm ok with dropping the line.

Best regards
Uwe

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)