netdev - Re: [PATCH 3/3] net: phy: bcm54811: Fix the PHY initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6083482b-59e2-4734-96d3-37c5a7597e9f@axis.com>
Date: Fri, 27 Jun 2025 10:11:19 +0200
From: Kamil Horák (2N) <kamilh@...s.com>
To: "Russell King (Oracle)" <linux@...linux.org.uk>
Cc: netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH 3/3] net: phy: bcm54811: Fix the PHY initialization



On 6/26/25 15:05, Russell King (Oracle) wrote:
> On Thu, Jun 26, 2025 at 01:56:19PM +0200, Kamil Horák - 2N wrote:
>> +		/* BCM54811 is not capable of LDS but the corresponding bit
>> +		 * in LRESR is set to 1 and marked "Ignore" in the datasheet.
>> +		 * So we must read the bcm54811 as unable to auto-negotiate
>> +		 * in BroadR-Reach mode.
>> +		 */
>> +		aneg = (BRCM_PHY_MODEL(phydev) != PHY_ID_BCM54811) ?
>> +			(val & LRESR_LDSABILITY) : 0;
> 
> Wouldn't:
> 
> 		if (BRCM_PHY_MODEL(phydev) == PHY_ID_BCM54811)
> 			aneg = 0;
> 		else
> 			aneg = val & LRESR_LDSABILITY;
> 
> be more readable?
yes of course
changed
>